Lazy base types #2813
Merged
Lazy base types #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I hope to make similar changes for indexers and return types of call and construct signatures. |
src/compiler/checker.ts
Outdated
Contributor
There was a problem hiding this comment.
we have ObjectType and ResolvedObjectType. Should we have InterfaceType and ResolvedInterfaceType?
Contributor
There was a problem hiding this comment.
you do the cast 4 times. Can you just cast once to a local, and then use that from then on?
Contributor
Author
There was a problem hiding this comment.
I can use a local. The problem with ResolvedInterfaceType is that it implies that the type elements (members, call signatures, etc) are resolved, and that is not in fact the case.
Contributor
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec section 3.9 does not say that interface / class types depend on their base types. And they shouldn't. However, the compiler eagerly resolves the base types of classes and interfaces, so if a class / interface is referenced by a type alias, it might lead to a circular reference error.
The issue can be seen in #1936.
The fix is to make collection of base types lazy, so that base type computation is done on demand when base types are needed.