Skip to content

Conversation

@sandersn
Copy link
Member

For 3.9

There are a lot of baseline changes with this one because the type of console.log changes from (message?: any, ...optionalArguments: any[]) to (...data: any[]), which is more sensible anyway. I don't think the first argument is different from the rest.

@sandersn
Copy link
Member Author

@orta reviewers list isn't working, so I'm tagging you this way in case you're interested. I'll merge after CI is green.

@sandersn sandersn merged commit 933c294 into master Mar 18, 2020
@sandersn sandersn deleted the dom-update-2020-03-18 branch March 18, 2020 23:08
cssText: string;
cursor: string;
direction: string;
display: string;
dominantBaseline: string;
emptyCells: string;
enableBackground: string | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described here, this is breaking the current recharts typings.

So heads-up to the maintainers of recharts: @rapmue, @royxue, @ZheyangSong, @richbai90, @caspeco-dan, @pkeuter, @jrsaunde, @CruseCtrl, @apalugniok, @RobertStigsson, @kousaku-maron, @iflp, @veddermatic, @G07cha, @gndelia, @dimitropoulos, @eliotball, @vkentta, @fcaylus, and @samuelweckstrom.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -2343,47 +2354,6 @@ declare var AudioScheduledSourceNode: {
new(): AudioScheduledSourceNode;
};

/** A single audio track from one of the HTML media elements, <audio> or <video>. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why these disappeared, they're still part of the standard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants