-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Dom update 2020-03-18 #37464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dom update 2020-03-18 #37464
Conversation
|
@orta reviewers list isn't working, so I'm tagging you this way in case you're interested. I'll merge after CI is green. |
| cssText: string; | ||
| cursor: string; | ||
| direction: string; | ||
| display: string; | ||
| dominantBaseline: string; | ||
| emptyCells: string; | ||
| enableBackground: string | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described here, this is breaking the current recharts typings.
So heads-up to the maintainers of recharts: @rapmue, @royxue, @ZheyangSong, @richbai90, @caspeco-dan, @pkeuter, @jrsaunde, @CruseCtrl, @apalugniok, @RobertStigsson, @kousaku-maron, @iflp, @veddermatic, @G07cha, @gndelia, @dimitropoulos, @eliotball, @vkentta, @fcaylus, and @samuelweckstrom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -2343,47 +2354,6 @@ declare var AudioScheduledSourceNode: { | |||
| new(): AudioScheduledSourceNode; | |||
| }; | |||
|
|
|||
| /** A single audio track from one of the HTML media elements, <audio> or <video>. */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why these disappeared, they're still part of the standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussion is in microsoft/TypeScript-DOM-lib-generator#802
For 3.9
There are a lot of baseline changes with this one because the type of console.log changes from
(message?: any, ...optionalArguments: any[])to(...data: any[]), which is more sensible anyway. I don't think the first argument is different from the rest.