Support semantic highlights for JS files #43992
Conversation
…t if we have a valid source file
…ic classification results
typescript-bot
added
Author: Team
For Uncommitted Bug
| const request = this.processRequest<protocol.EncodedSemanticClassificationsRequest>(protocol.CommandTypes.EncodedSemanticClassificationsFull, { file, start: span.start, length: span.length, format }); | ||
| const r = this.processResponse<protocol.EncodedSemanticClassificationsResponse>(request); | ||
| return r.body!; | ||
| } |
There was a problem hiding this comment.
This is the actual call which vscode uses, so I've replicated that codepath for the server tests. The non-encoded versions of the APIs aren't in the server, and it doesn't feel right to add them just for a test.
| if (actual.spans.length !== expected) { | ||
| this.raiseError(`encodedSemanticClassificationsLength failed - expected total spans to be ${expected} got ${actual.spans.length}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
So I can use the 'encoded' classifications routes in the server
src/services/services.ts
Outdated
| if (!isTsOrTsxFile(fileName)) { | ||
| synchronizeHostData(); | ||
| const sourceFile = program && program.getSourceFile(fileName); | ||
| if (!sourceFile) { |
There was a problem hiding this comment.
moves synchronizeHostData to the start of the function, then checks for the program and sourceFile. Only potential behavior change is that getValidSourceFile would previously have thrown when there is no source file and now it would return empty results.
There was a problem hiding this comment.
I think we should still keep getValidSourceFile as calling this on wrong LS is still error...
|
|
||
| // This test validates that an arbitrary JS file gets | ||
| // encoded semantic classifications when requested | ||
| verify.encodedSemanticClassificationsLength("2020", 9) |
There was a problem hiding this comment.
The above test is moved to the server subfolder, where it now goes through the same codepaths as vscode would
typescript-bot
added
For Milestone Bug
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
I think we should still keep getValidSourceFile call.. Other change of removing if statement that checks not TS is correct
3 participants
Fixes #43350 by allowing checking for the existence of a source file instead of limiting via filename.