Skip to content

Conversation

@sheetalkamat
Copy link
Member

No description provided.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 7, 2021
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code, but it looks consistent with the other cache.

@sheetalkamat
Copy link
Member Author

And i will add test as a separate PR so that we are not blocked on this for 4.3.1

@sheetalkamat sheetalkamat merged commit e61d812 into master May 7, 2021
@sheetalkamat sheetalkamat deleted the missingUpdate branch May 7, 2021 23:58
sheetalkamat added a commit that referenced this pull request May 8, 2021
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 10, 2021
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in microsoft#44004 works
sheetalkamat added a commit that referenced this pull request May 10, 2021
sheetalkamat added a commit that referenced this pull request May 10, 2021
Component commits:
8da9ed0 Test without change

5c1ae7a Update showing fix in #44004 works

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants