Skip to content

Conversation

@DanielRosenwasser
Copy link
Member

No description provided.

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@jakebailey
Copy link
Member

Missing the update to package-lock.json too.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 18, 2025
@DanielRosenwasser DanielRosenwasser merged commit 246507f into main Feb 18, 2025
32 checks passed
@DanielRosenwasser DanielRosenwasser deleted the bumpTo5.9 branch February 18, 2025 19:16
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@kachick
Copy link

kachick commented May 27, 2025

Is it intentional for this commit to be in v5.8.3? v5.8.2 seems to have the same version number in its package.json.

https://github.com/microsoft/TypeScript/blob/v5.8.3/package.json#L5
https://github.com/microsoft/TypeScript/blob/v5.8.2/package.json#L5

I noticed this while debugging NixOS/nixpkgs#398716.

@jakebailey
Copy link
Member

It's a mistake, but publishing to npm overrides this so what's on npm is correct (note the package.json there). If you're building from the source you may need to do that too, unfortunately.

@kachick
Copy link

kachick commented May 27, 2025

Thanks so much for the detailed response to my questions. I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants