Skip to content

Update default Git version to v2.53.0.vfs.0.5 in CI/PR builds#1925

Merged
mjcheetham merged 1 commit intomasterfrom
ci-gitver-bump
Mar 30, 2026
Merged

Update default Git version to v2.53.0.vfs.0.5 in CI/PR builds#1925
mjcheetham merged 1 commit intomasterfrom
ci-gitver-bump

Conversation

@mjcheetham
Copy link
Copy Markdown
Member

@mjcheetham mjcheetham commented Mar 27, 2026

Let's bump the default microsoft/git version that we build and test against in CI/PR runs to the current latest pre-release (v2.50.1.vfs.0.1 -> v2.53.0.vfs.0.5).

Note that the current full-release (v2.53.0.vfs.0.0) has bugs that prevent successful functional test runs, hence switching to a pre-release.

@mjcheetham mjcheetham requested a review from dscho March 27, 2026 11:19
@mjcheetham mjcheetham enabled auto-merge March 27, 2026 11:23
@mjcheetham
Copy link
Copy Markdown
Member Author

@tyrielv it looks like there's an issue with v2.53.0.vfs.0.0 that is causing three functional tests to fail:

1) Failed : GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForAllNullObject()
  Expected: 0
  But was:  128
   at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.RunGitResetHardWithCorruptObject(Action`1 corruptObject)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForAllNullObject()

2) Failed : GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForObjectCorruptedWithBadData()
  Expected string length 0 but was 469. Strings differ at index 0.
  Expected: <string.Empty>
  But was:  "# GVFS\r\n\r\nThis is a conflict for the rebase test\r\n\r\n## What i..."
  -----------^
   at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.RunGitCatFileWithCorruptObject(Action`1 corruptObject)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForObjectCorruptedWithBadData()

3) Failed : GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForTruncatedObject()
  The contents of C:\Repos\GVFSFunctionalTests\enlistment\3618f73a41eb474c9082\src\Readme.md do not match what was expected
  Expected string length 0 but was 469. Strings differ at index 0.
  Expected: <string.Empty>
  But was:  "# GVFS\r\n\r\nThis is a conflict for the rebase test\r\n\r\n## What i..."
  -----------^
   at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message)
   at GVFS.FunctionalTests.Should.FileSystemShouldExtensions.FileAdapter.WithContents(String expectedContents)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.RunGitResetHardWithCorruptObject(Action`1 corruptObject)
   at GVFS.FunctionalTests.Tests.EnlistmentPerFixture.GitCorruptObjectTests.GitRequestsReplacementForTruncatedObject()

@mjcheetham mjcheetham changed the title Update default GIT_VERSION in build workflow Update default Git version to v2.53.0.vfs.0.0 in CI/PR builds Mar 27, 2026
Let's bump the default microsoft/git version that we build and test
against in CI/PR runs to the latest pre-release (that works!).
@mjcheetham mjcheetham changed the title Update default Git version to v2.53.0.vfs.0.0 in CI/PR builds Update default Git version to v2.53.0.vfs.0.5 in CI/PR builds Mar 30, 2026
Copy link
Copy Markdown
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mjcheetham mjcheetham merged commit 6a508c5 into master Mar 30, 2026
53 checks passed
@dscho dscho deleted the ci-gitver-bump branch March 30, 2026 12:20
@mjcheetham mjcheetham mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants