Skip to content

Update default Microsoft Git version to v2.53.0.vfs.0.7#1948

Merged
dscho merged 1 commit intomasterfrom
automation/gitrelease-v2.53.0.vfs.0.7
Apr 17, 2026
Merged

Update default Microsoft Git version to v2.53.0.vfs.0.7#1948
dscho merged 1 commit intomasterfrom
automation/gitrelease-v2.53.0.vfs.0.7

Conversation

@mjcheetham
Copy link
Copy Markdown
Member

This PR was automatically created by the microsoft/git release workflow
to update the default Microsoft Git version to v2.53.0.vfs.0.7.

@dscho dscho enabled auto-merge April 17, 2026 10:51
@dscho dscho merged commit 96352b2 into master Apr 17, 2026
48 of 49 checks passed
@dscho dscho deleted the automation/gitrelease-v2.53.0.vfs.0.7 branch April 17, 2026 11:08
@dscho
Copy link
Copy Markdown
Member

dscho commented Apr 17, 2026

This is a known flake, right? @tyrielv @mjcheetham

1) Failed : GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()
  Last access time does not match
  Expected: 2026-04-18 11:01:49.3848373
  But was:  2026-04-17 11:01:48.5256993
   at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message)
   at GVFS.FunctionalTests.Should.FileSystemShouldExtensions.FileAdapter.WithInfo(DateTime creation, DateTime lastWrite, DateTime lastAccess)
   at GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()

Also: Do we want to mark the Build, Unit and Functional Tests Successful job as Required so that these PRs cannot auto-merge when the tests fail?

@tyrielv
Copy link
Copy Markdown
Contributor

tyrielv commented Apr 17, 2026

This is a known flake, right? @tyrielv @mjcheetham

1) Failed : GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()
  Last access time does not match
  Expected: 2026-04-18 11:01:49.3848373
  But was:  2026-04-17 11:01:48.5256993
   at GVFS.Tests.Should.ValueShouldExtensions.ShouldEqual[T](T actualValue, T expectedValue, String message)
   at GVFS.FunctionalTests.Should.FileSystemShouldExtensions.FileAdapter.WithInfo(DateTime creation, DateTime lastWrite, DateTime lastAccess)
   at GVFS.FunctionalTests.Tests.LongRunningEnlistment.BasicFileSystemTests.ExpandedFileAttributesAreUpdated()

Also: Do we want to mark the Build, Unit and Functional Tests Successful job as Required so that these PRs cannot auto-merge when the tests fail?

Yes, it's a known flake - I'm optimistic that upgrading from .NET framework to 10 will fix it.

I thought the job was already required - I've had PRs blocked by it before.

@dscho
Copy link
Copy Markdown
Member

dscho commented Apr 17, 2026

Yes, it's a known flake - I'm optimistic that upgrading from .NET framework to 10 will fix it.

Thank you for confirming!

I thought the job was already required - I've had PRs blocked by it before.

And so it is!

image

Strange thing, then, that this failure was allowed:

image

And even stranger that this is not marked as required:

image

In fact, no Checks seem to be marked as required in the Checks (guarded behind View details)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants