Implement skipped wslc E2E test - #41243
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables and implements previously skipped WSLC end-to-end coverage by replacing placeholder/disabled tests with working implementations that exercise the real CLI behavior (stdin import, terminal detection, and --pull behavior against a private registry source).
Changes:
- Implement
image importfrom stdin E2E by saving a tar archive and feeding it towslc image import - ...via a file-backed stdin handle. - Re-enable
image save“stdout is a terminal” failure E2E by runningwslcunder a pseudoconsole and waiting for the localized error output. - Re-enable
build --pullE2E by standing up a local registry, tagging/pushing a base image to it, and validating digest resolution appears in verbose build progress.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCE2EImageSaveTests.cpp | Replaces a skipped test with a pseudoconsole-backed interactive run validating “save to terminal” failure behavior. |
| test/windows/wslc/e2e/WSLCE2EImageImportTests.cpp | Implements the previously-not-implemented stdin import success path using a saved tarball as stdin. |
| test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp | Replaces an unstable skip with a local-registry-backed --pull test validating digest resolution in verbose output. |
| test/windows/wslc/e2e/WSLCE2EHelpers.h | Adds a shared helper declaration for waiting on pseudoconsole output substrings. |
| test/windows/wslc/e2e/WSLCE2EHelpers.cpp | Implements the pseudoconsole output wait helper and refactors tty-size waiting to reuse it. |
OneBlue
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Implement skipped wslc E2E test
Related:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed