wslc: Run saved state cleanup as user - #41259
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eed677b2-73d4-445c-b738-16123e81897b
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WSL’s Windows service VM teardown path to perform saved-state file cleanup while impersonating the owning user, aligning deletion/access context with how the saved-state file is created and managed elsewhere in HcsVirtualMachine.
Changes:
- Impersonate
m_userTokenbefore checking/removing the VM saved-state file duringHcsVirtualMachinedestruction.
benhillis
changed the title
OneBlue
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Runs VM saved-state file cleanup under the owning user's token, matching the context used when the file is created and accessed elsewhere.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The saved-state path is created while running as the owning user. This change applies the same user context when checking and removing that file during VM teardown.
Validation Steps Performed
cmake --build . -- -m.