Fix WSLC parser unit test argument overrides - #41496
Merged
Ben Hillis (benhillis) merged 1 commit intoSep 1, 2026
Merged
Conversation
Update the remaining parser test call site to use ArgumentOverrides after the Argument::Create API change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb7946ff-cc0b-4ff1-a059-571334b1c988
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward, correct API update in tests with no behavioral risk beyond restoring compilation.
Pull request overview
Updates the WSLC CLI parser unit tests to align with the newer Argument::Create(ArgType, ArgumentOverrides) factory API so the tests compile and continue validating parser behavior.
Changes:
- Convert the remaining parser test
Argument::Createcall from the legacy positional-parameter overload toArgumentOverrideswith.Limit = Limit::Unlimited.
File summaries
| File | Description |
|---|---|
| test/windows/wslc/WSLCCLIParserUnitTests.cpp | Updates test argument definitions to use ArgumentOverrides after the argument factory API change. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
beena352
approved these changes
Sep 1, 2026
David Bennett (dkbennett)
approved these changes
Sep 1, 2026
Member
|
looks like two PRs fixing the same issue submitted about a minute apart: #41497 |
Ben Hillis (benhillis)
enabled auto-merge (squash)
September 1, 2026 20:57
6 tasks
Ben Hillis (benhillis)
deleted the
user/benhill/fix-wslc-argument-overrides-test
branch
September 1, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Argument::Createparser test call to useArgumentOverridesValidation
./FormatSource.ps1 -ModifiedOnly $trueMicrosoft.WSL.Kernel.6.18.40.1-1package did not containbuild/native/bin/x64/modules.vhd