Skip to content

[dotnet-code] Extract skill deduplication helper #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmuntal merged 2 commits into from
Jun 25, 2026
Merged

[dotnet-code] Extract skill deduplication helper #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a05a52f
Extract skill deduplication helper
github-actions[bot] Jun 20, 2026
ead4e21
Merge branch 'main' into dotnet-code-skill-dedup-helper-e9ee938de644c6e4
michelle-clayton-work Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions agent/skills/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,18 +308,22 @@ func (p *providerState) loadSkills(ctx context.Context) ([]*Skill, error) {
if p.options.DisableSourceDeduplication {
return loaded, nil
}
seen := make(map[string]struct{}, len(loaded))
deduplicated := loaded[:0]
for _, skill := range loaded {
return deduplicateSkillsByName(loaded, p.logger), nil
}

func deduplicateSkillsByName(skills []*Skill, logger *slog.Logger) []*Skill {
seen := make(map[string]struct{}, len(skills))
deduplicated := skills[:0]
for _, skill := range skills {
resolvedKey := strings.ToLower(skill.Frontmatter.Name)
if _, ok := seen[resolvedKey]; ok {
p.logger.Warn("Duplicate skill name: subsequent skill skipped in favor of first occurrence", "skillName", skill.Frontmatter.Name)
logger.Warn("Duplicate skill name: subsequent skill skipped in favor of first occurrence", "skillName", skill.Frontmatter.Name)
continue
}
seen[resolvedKey] = struct{}{}
deduplicated = append(deduplicated, skill)
}
return deduplicated, nil
return deduplicated
}

func indexSkills(skills []*Skill) providedSkillSet {
Expand Down
Loading