Python: Fix SK migration samples#5047
Merged
Merged
Conversation
github-actions
Bot
changed the title
TaoChenOSU
enabled auto-merge
April 1, 2026 23:51
chetantoshniwal
approved these changes
Apr 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Semantic Kernel (SK) migration samples and CI sample-validation environment to align with SK’s current OpenAI Responses agent settings API, so the SK-side examples run successfully alongside Agent Framework (AF) equivalents.
Changes:
- Update SK Responses samples to use
responses_model_idandai_model_idinstead of the olderresponses_model/ai_modelfields. - Extend the
python-sample-validationworkflow job environment with SK-specific OpenAI/Azure OpenAI variables needed by the SK samples.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
python/samples/semantic-kernel-migration/openai_responses/01_basic_responses_agent.py |
Switches SK Responses model configuration to the *_model_id naming. |
python/samples/semantic-kernel-migration/openai_responses/02_responses_agent_with_tool.py |
Same model-setting update for the tool/plugin SK Responses sample. |
python/samples/semantic-kernel-migration/openai_responses/03_responses_agent_structured_output.py |
Same model-setting update for the structured-output SK Responses sample. |
.github/workflows/python-sample-validation.yml |
Adds SK-focused env vars/comments for semantic-kernel migration sample validation. |
eavanvalkenburg
approved these changes
Apr 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 2, 2026
alliscode
pushed a commit
to alliscode/agent-framework
that referenced
this pull request
Apr 3, 2026
* Fix SK migration samples * Fix env vars for SK * Hard code model for sheel tool samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix SK migration samples
Contribution Checklist