.NET: Standardize file skills terminology on 'directory'#5205
Merged
westey-m merged 1 commit intomicrosoft:mainfrom Apr 10, 2026
Merged
.NET: Standardize file skills terminology on 'directory'#5205westey-m merged 1 commit intomicrosoft:mainfrom
westey-m merged 1 commit intomicrosoft:mainfrom
Conversation
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
4 tasks
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes terminology across the .NET file-skills implementation to consistently use “folder” (aligned with the public API concepts ScriptFolders/ResourceFolders) instead of mixing “folder” and “directory”.
Changes:
- Renamed internal methods/variables/log messages in the file skills source from Directory → Folder terminology.
- Updated XML docs across the file skills types and provider builder/provider to use “folder” consistently.
- Updated unit tests to reflect the new terminology (helper names, test names, comments).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/Skills/File/AgentFileSkillsSource.cs | Renames internal discovery/parsing APIs and log messages to “folder” terminology; keeps filesystem APIs unchanged. |
| dotnet/src/Microsoft.Agents.AI/Skills/File/AgentFileSkillsSourceOptions.cs | Updates XML docs to describe scanning “skill folders”. |
| dotnet/src/Microsoft.Agents.AI/Skills/File/AgentFileSkill.cs | Updates public docs to refer to “folder” for discovered skill location. |
| dotnet/src/Microsoft.Agents.AI/Skills/File/AgentFileSkillResource.cs | Updates docs to refer to “skill folder” for relative resource naming. |
| dotnet/src/Microsoft.Agents.AI/Skills/AgentSkillsProviderBuilder.cs | Updates docs/remarks to refer to file skill “folders”. |
| dotnet/src/Microsoft.Agents.AI/Skills/AgentSkillsProvider.cs | Updates constructor docs to refer to a single “folder”. |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/FileAgentSkillLoaderTests.cs | Renames helpers/tests/comments to “folder” terminology. |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentFileSkillsSourceScriptTests.cs | Updates comment wording (“subfolder recursion”). |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentSkillsProviderTests.cs | Renames a test to “SingleFolder”. |
westey-m
approved these changes
Apr 10, 2026
Rename authored identifiers, XML docs, log messages, and comments from 'folder' to 'directory' across the file skills codebase for consistency with the agentskills.io specification and .NET conventions. Public API changes (experimental): - ScriptFolders → ScriptDirectories - ResourceFolders → ResourceDirectories .NET BCL API calls (Directory.Exists, Path.GetDirectoryName, etc.) were already using 'directory' and are unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
force-pushed
the
standardize-folder-terminology
branch
from
e050218 to
b9c67be
Compare
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
changed the title
rogerbarreto
approved these changes
Apr 10, 2026
SergeyMenshykh
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize the file skills codebase to use "directory" consistently instead of mixing "folder" and "directory" for the same concept. This aligns with the agentskills.io specification which uses "directory" exclusively, and with .NET BCL conventions (
Directory,DirectoryInfo).Public API changes (experimental)
ScriptFolders→ScriptDirectoriesResourceFolders→ResourceDirectoriesInternal changes
Source files:
AgentFileSkillsSource.cs— constants (RootFolderIndicator→RootDirectoryIndicator), fields, method params, loop variables, log methods/messages, XML docs, and commentsAgentFileSkillsSourceOptions.cs— property renames + XML docsTest files:
FileAgentSkillLoaderTests.cs— updated property references, test method names, variable names, comments, and test fixture namesAgentFileSkillsSourceScriptTests.cs— updated property references, test method names, variable names, and comments