-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[BREAKING] Python: restrict checkpoint deserialization in FoundryCheckpointStore #8045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sriraj (sricursion)
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
sricursion:foundry-hosting-restrict-checkpoint-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+159
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense for
CheckpointStoreProviderto accept and forwardallowed_checkpoint_typeshere?ResponsesHostServercreates stores through this provider, so hosted apps cannot use the new per-store option on the normal path and must either register types process-wide or replace the whole provider. Threading the list throughCheckpointStoreProvider.__init__would keep the new configuration reachable without changing its behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — you're right, and it made the change worse than it needed to be. With the option only on the store, a hosted app on the default path had no way to reach it, so its only recourse for a checkpoint carrying its own type was process-wide registration or replacing the provider.
Pushed 9fad234:
CheckpointStoreProvider.__init__takesallowed_checkpoint_typesand forwards it to every store it creates. Keyword-only with aNonedefault, soCheckpointStoreProvider()behaves exactly as before.Two tests added: one asserting a type named through the provider survives a
load, and one asserting a provider built with no arguments still restricts. The first fails without the change withTypeError: CheckpointStoreProvider() takes no arguments, which is the gap you described.