Add directive support for fab-dropdown #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengry
suggested changes
Mar 20, 2019
Contributor
bengry
left a comment
bengry
left a comment
There was a problem hiding this comment.
-
Mainly concerned about the removal of the
ContentChildfromFabBaseComboBoxComponent. -
Also, what i18n support is added here? Just the fact that it's now in the template and you can use the native Angular i18n (
<my-button text="foo" i18n-text></my-button>)?
libs/fabric/src/lib/components/dropdown/directives/dropdown-options.directive.ts
Show resolved
Hide resolved
libs/fabric/src/lib/components/dropdown/directives/dropdown-options.directive.ts
Outdated
Show resolved
Hide resolved
bengry
approved these changes
Mar 20, 2019
bengry
suggested changes
Mar 20, 2019
Contributor
bengry
left a comment
bengry
left a comment
There was a problem hiding this comment.
- Please make sure that the imperative syntax of
optionsstill works as it did before, in addition to the declarative syntax. - What happens when both syntaxes for
optionsare used at the same time?
bengry
approved these changes
Mar 20, 2019
Contributor
|
@reshaw Note that you can also directly make a PR from within this repo. Since you're in the Commercial Stores team you have the permissions to create branches etc. Will merge this once CLA reports the status, no idea why it didn't yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add directives to support i18n for fab-dropdown
-Add demo of new directive-supported fab-dropdown to app.component
-Minor cleanup of directives for fab-combo-box