Skip to content

Conversation

@xjerwa
Copy link
Contributor

@xjerwa xjerwa commented Dec 5, 2018

No description provided.

@xjerwa xjerwa requested a review from bengry December 5, 2018 22:32
@bengry
Copy link
Contributor

bengry commented Dec 5, 2018

If I understand correctly, the geteventlisteners code is now in the tarball, modified from the original one? If so, what's the point in keeping it as an external dependency rather than just copying it over into our code?

@bengry bengry merged commit 79c6389 into master Dec 6, 2018
@bengry bengry deleted the pr/48 branch December 6, 2018 15:18
@bengry
Copy link
Contributor

bengry commented Dec 6, 2018

@xjerwa I fixed up some minor stuff and merged it to master, this is included in v0.5.2 in #53 (v0.5.1 was a bad version, I deprecated it in npm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants