chore(package): updated dependencies #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NathanWalker
commented
Jan 15, 2019
NathanWalker
commented
- Just updated packages to latest 👍
|
|
Contributor
|
@NathanWalker looks good. Please verify that this still works with Angular 7.0.x and 7.1.x apps before we merge this. There should be no issues, but I still prefer that we double check this, given that the compiler updated. |
Contributor
Author
|
@bengry sure thing. I setup this Nx workspace using 7.0.x and built angular-react using the latest here which is included in that workspace in custom packed modules. You can use this repo to test against different Angular version to verify. Given 7.0.x works great with latest builds I would assume 7.1.x would as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.