Skip to content

[Core] Workaround for TemplateRef update issues #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bengry merged 2 commits into from
Jan 26, 2019
Merged

[Core] Workaround for TemplateRef update issues #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b91627
fix template context assumed to always exist
bengry Jan 26, 2019
9210187
always get the leading and trailing values, to ensure that we stay up…
bengry Jan 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions libs/core/src/lib/renderer/react-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ export class ReactTemplate<TContext extends object | void> extends React.Compone

componentDidUpdate() {
// Context has changes, trigger change detection after pushing the new context in
Object.assign(this._embeddedViewRef.context, this.props.context);
if (this.props.context != null && this._embeddedViewRef.context != null) {
Object.assign(this._embeddedViewRef.context, this.props.context);
}
this._embeddedViewRef.detectChanges();
}

Expand All @@ -86,9 +88,11 @@ export class ReactTemplate<TContext extends object | void> extends React.Compone

// Throttling the detect changes to an empirically selected value so we don't overload too much work.
// TODO: This needs some better solution to listen to changes to the binding sources of the template.
this._ngZoneSubscription = ngZone.onStable.pipe(throttleTime(TEMPLATE_DETECT_CHANGES_THROTTLE_MS)).subscribe(() => {
this._embeddedViewRef.detectChanges();
});
this._ngZoneSubscription = ngZone.onStable
.pipe(throttleTime(TEMPLATE_DETECT_CHANGES_THROTTLE_MS, undefined, { leading: true, trailing: true }))
.subscribe(() => {
this._embeddedViewRef.detectChanges();
});
}

componentWillUnmount() {
Expand Down