Skip to content

Fix/hermes command support#1986

Closed
glesperance wants to merge 2 commits intomicrosoft:masterfrom
Paltap-io:fix/hermes-command-support
Closed

Fix/hermes command support#1986
glesperance wants to merge 2 commits intomicrosoft:masterfrom
Paltap-io:fix/hermes-command-support

Conversation

@glesperance
Copy link
Copy Markdown
Contributor

Ready to merge version of #1325:

If the hermesCommand option is present in build.gradle then this path will be used as the path to the hermes executable when running codepush release-react

This allows the release-react command to be used in monorepos where the node_modules directory may be at the root of the monorepo rather then in the project and fixes this issue here: #1170

Chris Green and others added 2 commits March 13, 2021 19:48
If the hermesCommand path is set in build.gradle, this will be used instead of the default path.
@ghost
Copy link
Copy Markdown

ghost commented Jul 1, 2022

CLA assistant check
All CLA requirements met.

@YangJonghun
Copy link
Copy Markdown

YangJonghun commented Jul 2, 2022

not works properly with below react-native-code-push code

...download bundle...
await localPackage.install(CodePush.InstallMode.ON_NEXT_RESTART)
CodePush.restartApp(true)

also, latest bundle not applied even if restart app after fully closed

update: it probably react-native-reanimated issue related hermes

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

AnatolyPristensky commented Jul 5, 2022

Hello @glesperance,
Thank you so much for your contribute, we will check it and get back to you once get results

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

@glesperance , the CI is failing with the following error message:
/home/vsts/work/1/s/src/commands/codepush/lib/react-native-utils.ts
488:1 error Delete ·· prettier/prettier

Could you please have a look?

@safaiyeh
Copy link
Copy Markdown

safaiyeh commented Aug 2, 2022

@AnatolyPristensky I can help resolve the errors, if that's welcomed! We want this feature

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

@AnatolyPristensky I can help resolve the errors, if that's welcomed! We want this feature

Hello @safaiyeh, actually we will fix the CI by ourselves, but also we need some time to test these changes.

@AnatolyPristensky
Copy link
Copy Markdown
Contributor

These changes are presented in #2052
@glesperance, thank you for your contribution! I'm closing this one as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants