Use the hermesCommand path from build.gradle when running release-react command#1325
Closed
chrisgreen1993 wants to merge 1 commit intomicrosoft:masterfrom
Closed
Use the hermesCommand path from build.gradle when running release-react command#1325chrisgreen1993 wants to merge 1 commit intomicrosoft:masterfrom
chrisgreen1993 wants to merge 1 commit intomicrosoft:masterfrom
Conversation
If the hermesCommand path is set in build.gradle, this will be used instead of the default path.
|
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@russelarms any way we can help getting this merged and released? |
Contributor
|
@glesperance Thanks for the help. |
Contributor
|
Closing as a duplicate of #1988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
hermesCommandoption is present inbuild.gradlethen this path will be used as the path to the hermes executable when runningcodepush release-reactThis allows the
release-reactcommand to be used in monorepos where thenode_modulesdirectory may be at the root of the monorepo rather then in the project and fixes this issue here: #1170Related issue: #1987