Use hermes bundled with React Native

[zolbooo]

This PR updates release-react command to use node_modules/react-native/sdks/hermesc, if exists. This allows codepush to use latest version of Hermes bundled with react-native.

More details about bundled Hermes: https://reactnative.dev/architecture/bundled-hermes

Fixes #1987.

[YangJonghun]

not works properly with below react-native-code-push code

...download bundle...
await localPackage.install(CodePush.InstallMode.ON_NEXT_RESTART)
CodePush.restartApp(true)

above code occurred crash and only works when application restart after fully closed

[zolbooo]

not works properly with below react-native-code-push code

...
await localPackage.install(CodePush.InstallMode.ON_NEXT_RESTART)
CodePush.restartApp(true)

above code occurred crash and only works when application restart after fully closed

Could provide a react-native version and crash logs?

[YangJonghun]

react-native: 0.69.1
crash log just provide message Cannot figure out the cause

[zolbooo]

react-native: 0.69.1

crash log just provide message Cannot figure out the cause

Is it Android? If it is, you can use logcat to provide crash stacktrace from the Android Studio.

[YangJonghun]

react-native: 0.69.1
crash log just provide message Cannot figure out the cause

Is it Android? If it is, you can use logcat to provide crash stacktrace from the Android Studio.

I copied from Flipper's crash reporter (same as logcat)

*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
... device info...
backtrace:
      #00 pc 00000000002e1a98  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)
      #01 pc 00000000002e1960  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)
      #02 pc 00000000002e190c  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)
      #03 pc 00000000002d73d4  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)
      #04 pc 0000000000148998  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libreanimated.so (reanimated::NativeProxy::~NativeProxy()+72) (BuildId: B...)
      #05 pc 0000000000148b30  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libreanimated.so (reanimated::NativeProxy::~NativeProxy()+36) (BuildId: B...)
*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***

my problem probably related with react-native-reanimated (I used version v2.9.1 in my project)

[zolbooo]

react-native: 0.69.1

crash log just provide message Cannot figure out the cause

Is it Android? If it is, you can use logcat to provide crash stacktrace from the Android Studio.

I copied from Flipper's crash reporter (same as logcat)

*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***

... device info...

backtrace:

      #00 pc 00000000002e1a98  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)

      #01 pc 00000000002e1960  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)

      #02 pc 00000000002e190c  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)

      #03 pc 00000000002d73d4  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libhermes-executor-debug.so (BuildId: A...)

      #04 pc 0000000000148998  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libreanimated.so (reanimated::NativeProxy::~NativeProxy()+72) (BuildId: B...)

      #05 pc 0000000000148b30  /data/app/~~4q3iFniVJrs2ggXD7Lat-w==/com.sample.sample-ENgm5I8Cf8i1afL3Dn6mRw==/lib/arm64/libreanimated.so (reanimated::NativeProxy::~NativeProxy()+36) (BuildId: B...)

*** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***

my problem probably related with react-native-reanimated (I used version v2.9.1 in my project)

I believe you should create an issue in react-native-reanimated repo. Don't forget to provide a repro 😉

[DmitriyKirakosyan]

Hi @zolbooo , thank you for your contribution!
Will this work if we run the command outside the project dir?

[zolbooo]

Hi @zolbooo , thank you for your contribution!

Will this work if we run the command outside the project dir?

I am not sure, the fix is using same principle as hermes-engine package detection.

[AnatolyPristensky]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).