Skip to content

Gate operator correctness tests behind ARK_UT_CORRECTNESS=1 env var#251

Merged
chhwang merged 2 commits into
mainfrom
pr-b-ut-gate
Jun 9, 2026
Merged

Gate operator correctness tests behind ARK_UT_CORRECTNESS=1 env var#251
chhwang merged 2 commits into
mainfrom
pr-b-ut-gate

Conversation

@chhwang

@chhwang chhwang commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Gate operator correctness tests behind ARK_UT_CORRECTNESS=1 env var

op_test() calls — GPU execution with numerical comparison against CPU
baselines — now check ARK_UT_CORRECTNESS=1 at runtime. When unset,
op_test() prints [SKIP] and returns immediately. Model-validation
tests (graph construction, shape inference, error paths) always run.

Changes:

  • ark/ops/ops_test_common.cpp: early-return in op_test() when
    ARK_UT_CORRECTNESS is not "1".
  • ark/CMakeLists.txt: CTest label correctness on the 11 test
    binaries that call op_test().
  • .github/workflows/ut.yml: two-step ctest — step 1 runs all 37
    binaries (correctness tests hit the skip path, ~0.03 s each); step 2
    runs ARK_UT_CORRECTNESS=1 ctest -L correctness for full GPU
    validation. gcov merges .gcda counters across both runs, so
    coverage captures both code paths.

No tests deleted or weakened. CI runs both steps on every push and PR.

…_UT_CORRECTNESS=1 env var; add CTest label; update CI workflow to run both steps.
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (0559ce2) to head (a586ac2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   86.85%   86.89%   +0.04%     
==========================================
  Files         125      125              
  Lines        6099     6113      +14     
==========================================
+ Hits         5297     5312      +15     
+ Misses        802      801       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…_UT_CORRECTNESS=1 env var; add CTest label; update CI workflow to run both steps.
@chhwang chhwang changed the title ark-dev: Gate operator correctness tests (op_test() calls) behind ARK_UT_CORRECTNESS=1 env var; add CTest label; update CI workflow to run both steps. Gate operator correctness tests behind ARK_UT_CORRECTNESS=1 env var Jun 8, 2026
@chhwang
chhwang merged commit 75de9b4 into main Jun 9, 2026
10 of 11 checks passed
@chhwang
chhwang deleted the pr-b-ut-gate branch June 9, 2026 01:13
chhwang added a commit that referenced this pull request Jun 9, 2026
Resolve conflict in ark/ops/ops_test_common.cpp: keep both
ARK_UT_CORRECTNESS env-var gating (#251) and GPU-count skip guard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant