Update CI workflow owner guards and repo references from dotnet to microsoft#15452
Conversation
Updated all GitHub Actions workflow owner guards from repository_owner == 'dotnet' to repository_owner == 'microsoft' across 24 workflow files. Replaced all dotnet/aspire repository references with microsoft/aspire across 288 files including workflows, scripts, tests, READMEs, source code, templates, and documentation. Preserved aka.ms short links pointing to dotnet/aspire as those are external redirects. Fixed SigstoreNpmProvenanceCheckerTests expectedOwner to match the updated URL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the repository’s CI guards and internal references to reflect the move from dotnet/aspire to microsoft/aspire, ensuring GitHub Actions jobs and documentation/scripts no longer silently skip or point at the old repo.
Changes:
- Updated GitHub Actions workflow owner guards from
github.repository_owner == 'dotnet'to... == 'microsoft'. - Rewrote
dotnet/aspirelinks/references tomicrosoft/aspireacross scripts, docs, READMEs, source comments, and tests. - Updated URL parsing expectations in
SigstoreNpmProvenanceCheckerTests.
Reviewed changes
Copilot reviewed 288 out of 288 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/README.md | Update repo URLs in usage docs |
| tools/scripts/DownloadFailingJobLogs.cs | Default repo set to microsoft/aspire |
| tools/ReleaseNotes/docs/commit-analysis.md | Update PR links to microsoft/aspire |
| tools/ReleaseNotes/docs/api-documentation.md | Update docs root references |
| tools/ReleaseNotes/data/whats-new-93.md | Update GitHub links/references |
| tools/ReleaseNotes/data/whats-new-92.md | Update GitHub/xref references |
| tools/QuarantineTools/README.md | Update issue links to microsoft/aspire |
| tests/Shared/TemplatesTesting/BuildEnvironment.cs | Update documentation link in error message |
| tests/Shared/Hex1bTestHelpers.cs | Update gh/raw URLs for PR bundle install |
| tests/Aspire.TestUtilities/RequiresFeatureAttribute.cs | Update issue links in comments |
| tests/Aspire.Templates.Tests/PerTestFrameworkTemplatesTests.cs | Update ActiveIssue URL |
| tests/Aspire.Templates.Tests/BuildAndRunTemplateTests.cs | Update ActiveIssue URL |
| tests/Aspire.Templates.Tests/Aspire.Templates.Tests.csproj | Update issue link in comment |
| tests/Aspire.StackExchange.Redis.Tests/AspireRedisExtensionsTests.cs | Update issue link in XML docs |
| tests/Aspire.RabbitMQ.Client.Tests/AspireRabbitMQLoggingTests.cs | Update ActiveIssue URL |
| tests/Aspire.Pomelo.EntityFrameworkCore.MySql.Tests/AspireEFMySqlExtensionsTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Pomelo.EntityFrameworkCore.MySql.Tests/Aspire.Pomelo.EntityFrameworkCore.MySql.Tests.csproj | Update PR link in comment |
| tests/Aspire.Playground.Tests/ProjectSpecificTests.cs | Update quarantine/issue URLs |
| tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj | Update issue link in comment |
| tests/Aspire.Playground.Tests/AppHostTests.cs | Update quarantine/issue URLs in comments |
| tests/Aspire.Hosting.Yarp.Tests/YarpFunctionalTests.cs | Update QuarantinedTest URL |
| tests/Aspire.Hosting.Valkey.Tests/ValkeyFunctionalTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs | Update ActiveIssue URL + BOM cleanup |
| tests/Aspire.Hosting.Tests/Utils/TestDistributedApplicationBuilder.cs | Update PR discussion link |
| tests/Aspire.Hosting.Tests/SlimTestProgramTests.cs | Update QuarantinedTest URLs |
| tests/Aspire.Hosting.Tests/Pipelines/DistributedApplicationPipelineTests.cs | Update issue link + BOM cleanup |
| tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs | Update QuarantinedTest URLs |
| tests/Aspire.Hosting.Tests/ContainerTunnelTests.cs | Update ActiveIssue URL |
| tests/Aspire.Hosting.Tests/Backchannel/Exec/ProjectResourceExecTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Hosting.Testing.Tests/TestingFactoryTests.cs | Update ActiveIssue URL |
| tests/Aspire.Hosting.Sdk.Tests/NuGetUtils.Tests.cs | Update issue link in comment |
| tests/Aspire.Hosting.Python.Tests/AddPythonAppTests.cs | Update ActiveIssue URL |
| tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs | Update ActiveIssue/Skip URLs |
| tests/Aspire.Hosting.OpenAI.Tests/OpenAIFunctionalTests.cs | Update QuarantinedTest URL |
| tests/Aspire.Hosting.Kubernetes.Tests/KubernetesEnvironmentResourceTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Hosting.Kafka.Tests/KafkaFunctionalTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Hosting.JavaScript.Tests/NodeFunctionalTests.cs | Update ActiveIssue URLs + BOM cleanup |
| tests/Aspire.Hosting.Docker.Tests/DockerComposeTests.cs | Update ActiveIssue URL + BOM cleanup |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/RoleAssignmentTests.SqlSupport.verified.bicep | Update issue URL in embedded script |
| tests/Aspire.Hosting.Azure.Tests/AzureServiceBusExtensionsTests.cs | Update issue URLs in skip messages + BOM cleanup |
| tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceTests.cs | Update issue link in comment |
| tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs | Update QuarantinedTest URL |
| tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs | Update issue URLs + BOM cleanup |
| tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs | Update issue link in comment |
| tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceTests.cs | Update issue link in comment |
| tests/Aspire.Hosting.Azure.Tests/AzureAppServiceTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Hosting.Azure.Kusto.Tests/KustoFunctionalTests.cs | Update ActiveIssue URLs |
| tests/Aspire.EndToEnd.Tests/README.md | Update PR link |
| tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2ETestHelpers.cs | Update raw script URL |
| tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2EAutomatorHelpers.cs | Update raw/gh API URLs |
| tests/Aspire.Deployment.EndToEnd.Tests/AcaDeploymentErrorOutputTests.cs | Update issue link in remarks |
| tests/Aspire.Dashboard.Tests/CircularBufferTests.cs | Update issue link in comment |
| tests/Aspire.Confluent.Kafka.Tests/OtelTracesTests.cs | Update ActiveIssue URL |
| tests/Aspire.Confluent.Kafka.Tests/OtelMetricsTests.cs | Update ActiveIssue URL |
| tests/Aspire.Components.Common.TestUtilities/ConformanceTests.cs | Update ActiveIssue URLs |
| tests/Aspire.Components.Common.TestUtilities/Aspire.Components.Common.TestUtilities.csproj | Update PR link in comment |
| tests/Aspire.Cli.Tests/Projects/ProjectUpdaterTests.cs | Update issue link in comment |
| tests/Aspire.Cli.Tests/Projects/ProjectLocatorTests.cs | Update issue links in XML docs |
| tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs | Update PR/issue links in comments |
| tests/Aspire.Cli.Tests/Commands/RunCommandTests.cs | Update ActiveIssue URL |
| tests/Aspire.Cli.Tests/Agents/SigstoreNpmProvenanceCheckerTests.cs | Update expected owner/repo parsing test |
| tests/Aspire.Cli.EndToEnd.Tests/WaitCommandTests.cs | Update QuarantinedTest URL |
| tests/Aspire.Cli.EndToEnd.Tests/StopNonInteractiveTests.cs | Update issue link in summary |
| tests/Aspire.Cli.EndToEnd.Tests/SmokeTests.cs | Update issue link in comment + BOM cleanup |
| tests/Aspire.Cli.EndToEnd.Tests/PlaywrightCliInstallTests.cs | Update issue link in XML docs |
| tests/Aspire.Cli.EndToEnd.Tests/JsReactTemplateTests.cs | Update issue link in comment |
| tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs | Update raw/gh API URLs |
| tests/Aspire.Cli.EndToEnd.Tests/BannerTests.cs | Update ActiveIssue URL |
| tests/Aspire.Azure.Storage.Queues.Tests/AspireQueueStorageExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Storage.Files.DataLake.Tests/AspireDataLakeExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Storage.Blobs.Tests/AspireBlobStorageExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Security.KeyVault.Tests/AspireKeyVaultExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Search.Documents.Tests/AspireAzureSearchExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Messaging.ServiceBus.Tests/AspireServiceBusExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Messaging.EventHubs.Tests/AspireEventHubsExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.Data.Tables.Tests/AspireTablesExtensionsTests.cs | Update issue link in comment |
| tests/Aspire.Azure.AI.OpenAI.Tests/AspireAzureAIOpenAIExtensionsTests.cs | Update issue link in comment |
| src/Components/README.md | Update contribution text repo reference |
| src/Components/Aspire.StackExchange.Redis/README.md | Update repo links |
| src/Components/Aspire.StackExchange.Redis.OutputCaching/README.md | Update repo links |
| src/Components/Aspire.StackExchange.Redis.DistributedCaching/README.md | Update repo links |
| src/Components/Aspire.Seq/README.md | Update repo links |
| src/Components/Aspire.RabbitMQ.Client/README.md | Update repo links |
| src/Components/Aspire.RabbitMQ.Client/AspireRabbitMQExtensions.cs | Update issue link in comment |
| src/Components/Aspire.Qdrant.Client/README.md | Update repo links |
| src/Components/Aspire.Pomelo.EntityFrameworkCore.MySql/README.md | Update repo links |
| src/Components/Aspire.Oracle.EntityFrameworkCore/README.md | Update repo links |
| src/Components/Aspire.OpenAI/README.md | Update repo links |
| src/Components/Aspire.Npgsql/README.md | Update repo links |
| src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/README.md | Update repo links |
| src/Components/Aspire.NATS.Net/README.md | Update repo links |
| src/Components/Aspire.MySqlConnector/README.md | Update repo links |
| src/Components/Aspire.MongoDB.EntityFrameworkCore/README.md | Update repo links |
| src/Components/Aspire.MongoDB.Driver/README.md | Update repo links |
| src/Components/Aspire.Milvus.Client/README.md | Update repo links |
| src/Components/Aspire.Microsoft.Extensions.Configuration.AzureAppConfiguration/README.md | Update repo links |
| src/Components/Aspire.Microsoft.EntityFrameworkCore.SqlServer/README.md | Update repo links |
| src/Components/Aspire.Microsoft.EntityFrameworkCore.Cosmos/README.md | Update repo links |
| src/Components/Aspire.Microsoft.Data.SqlClient/README.md | Update repo links |
| src/Components/Aspire.Microsoft.Azure.StackExchangeRedis/README.md | Update repo links |
| src/Components/Aspire.Microsoft.Azure.Cosmos/README.md | Update repo links |
| src/Components/Aspire.Keycloak.Authentication/README.md | Update repo links |
| src/Components/Aspire.Confluent.Kafka/README.md | Update repo links |
| src/Components/Aspire.Azure.Storage.Queues/README.md | Update repo links |
| src/Components/Aspire.Azure.Storage.Files.DataLake/README.md | Update repo links |
| src/Components/Aspire.Azure.Storage.Blobs/README.md | Update repo links |
| src/Components/Aspire.Azure.Security.KeyVault/README.md | Update repo links |
| src/Components/Aspire.Azure.Search.Documents/README.md | Update repo links |
| src/Components/Aspire.Azure.Npgsql/README.md | Update repo links |
| src/Components/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL/README.md | Update repo links |
| src/Components/Aspire.Azure.Messaging.WebPubSub/README.md | Update repo links |
| src/Components/Aspire.Azure.Messaging.ServiceBus/README.md | Update repo links |
| src/Components/Aspire.Azure.Messaging.EventHubs/README.md | Update repo links |
| src/Components/Aspire.Azure.Data.Tables/README.md | Update repo links |
| src/Components/Aspire.Azure.AI.OpenAI/README.md | Update repo links |
| src/Components/Aspire.Azure.AI.Inference/README.md | Update repo links |
| src/Aspire.ProjectTemplates/Aspire.ProjectTemplates.csproj | Update PR link in comment |
| src/Aspire.Hosting/README.md | Update spec link + repo link |
| src/Aspire.Hosting/Health/ResourceHealthCheckService.cs | Update issue link in comment |
| src/Aspire.Hosting/Exec/ExecResourceManager.cs | Update issue link in comment |
| src/Aspire.Hosting/DotnetToolResourceExtensions.cs | Update PR link in comment |
| src/Aspire.Hosting/DistributedApplicationBuilder.cs | Update issue link in comment |
| src/Aspire.Hosting/Dcp/DcpExecutor.cs | Update issue/spec links in comments |
| src/Aspire.Hosting/ApplicationModel/CommandsConfigurationExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.Yarp/README.md | Update repo link |
| src/Aspire.Hosting.Valkey/ValkeyBuilderExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.Valkey/README.md | Update repo links |
| src/Aspire.Hosting.SqlServer/README.md | Update repo link |
| src/Aspire.Hosting.Seq/README.md | Update repo link |
| src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.Redis/README.md | Update repo link |
| src/Aspire.Hosting.RabbitMQ/README.md | Update repo link |
| src/Aspire.Hosting.Qdrant/README.md | Update repo link |
| src/Aspire.Hosting.Qdrant/QdrantBuilderExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.PostgreSQL/README.md | Update repo link |
| src/Aspire.Hosting.Orleans/README.md | Update repo link |
| src/Aspire.Hosting.Oracle/README.md | Update repo link |
| src/Aspire.Hosting.OpenAI/README.md | Update repo links |
| src/Aspire.Hosting.Nats/README.md | Update repo link |
| src/Aspire.Hosting.MySql/README.md | Update repo link |
| src/Aspire.Hosting.MongoDB/README.md | Update repo link |
| src/Aspire.Hosting.Milvus/README.md | Update repo link |
| src/Aspire.Hosting.Milvus/MilvusContainerImageTags.cs | Update issue link in comment |
| src/Aspire.Hosting.Maui/README.md | Update issues link |
| src/Aspire.Hosting.Kubernetes/README.md | Update repo link |
| src/Aspire.Hosting.Kubernetes/KubernetesResource.cs | Update issue link in comment |
| src/Aspire.Hosting.Kubernetes/Extensions/ResourceExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.Keycloak/README.md | Update repo link |
| src/Aspire.Hosting.Kafka/README.md | Update repo link |
| src/Aspire.Hosting.JavaScript/README.md | Update samples + repo links |
| src/Aspire.Hosting.GitHub.Models/README.md | Update repo links |
| src/Aspire.Hosting.Garnet/README.md | Update repo links |
| src/Aspire.Hosting.Garnet/GarnetBuilderExtensions.cs | Update issue link in comment |
| src/Aspire.Hosting.Foundry/README.md | Update repo links |
| src/Aspire.Hosting.Docker/README.md | Update repo link |
| src/Aspire.Hosting.DevTunnels/README.md | Update repo link |
| src/Aspire.Hosting.Azure/README.md | Update repo link |
| src/Aspire.Hosting.Azure.WebPubSub/README.md | Update repo links |
| src/Aspire.Hosting.Azure.Storage/README.md | Update repo links |
| src/Aspire.Hosting.Azure.Sql/README.md | Update repo links |
| src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Update issue link in script comment |
| src/Aspire.Hosting.Azure.SignalR/README.md | Update repo links |
| src/Aspire.Hosting.Azure.ServiceBus/README.md | Update repo links |
| src/Aspire.Hosting.Azure.Search/README.md | Update repo links |
| src/Aspire.Hosting.Azure.Redis/README.md | Update repo links |
| src/Aspire.Hosting.Azure.PostgreSQL/README.md | Update repo links |
| src/Aspire.Hosting.Azure.OperationalInsights/README.md | Update repo link |
| src/Aspire.Hosting.Azure.Network/README.md | Update repo link |
| src/Aspire.Hosting.Azure.Kusto/README.md | Update repo link |
| src/Aspire.Hosting.Azure.Functions/README.md | Update repo link |
| src/Aspire.Hosting.Azure.EventHubs/README.md | Update repo links |
| src/Aspire.Hosting.Azure.CosmosDB/README.md | Update repo links |
| src/Aspire.Hosting.Azure.CognitiveServices/README.md | Update repo links |
| src/Aspire.Hosting.Azure.ApplicationInsights/README.md | Update repo link |
| src/Aspire.Hosting.Azure.AppService/README.md | Update repo link |
| src/Aspire.Hosting.Azure.AppContainers/ContainerAppJobContext.cs | Update issue link in comment |
| src/Aspire.Hosting.Azure.AppContainers/ContainerAppContext.cs | Update issue link in comment |
| src/Aspire.Hosting.Azure.AppConfiguration/README.md | Update repo link |
| src/Aspire.Hosting.AppHost/build/Aspire.Hosting.AppHost.props | Update issue link in comment |
| src/Aspire.Hosting.AppHost/README.md | Update repo link |
| src/Aspire.Dashboard/Model/ResourceViewModel.cs | Update issue link in comment |
| src/Aspire.Cli/Utils/ConfigurationHelper.cs | Update issue link in comment |
| src/Aspire.Cli/Utils/CliHostEnvironment.cs | Update issue link in comment |
| src/Aspire.Cli/Templating/DotNetTemplateFactory.cs | Update issue link in comment |
| src/Aspire.Cli/README.md | Update Learn link + repo link |
| src/Aspire.Cli/Projects/ProjectLocator.cs | Update issue link in comment |
| src/Aspire.Cli/Projects/LanguageService.cs | Update issue link in comment |
| src/Aspire.Cli/Projects/GuestAppHostProject.cs | Update issue link in comment |
| src/Aspire.Cli/Program.cs | Update issue link in comment |
| src/Aspire.Cli/NuGet/NuGetPackagePrefetcher.cs | Update issue link in comment |
| src/Aspire.Cli/Interaction/ConsoleInteractionService.cs | Update issue link in remarks |
| src/Aspire.Cli/Configuration/ConfigurationService.cs | Update issue link in comment |
| src/Aspire.Cli/Configuration/AspireConfigFile.cs | Update issue links in comments/remarks |
| src/Aspire.Cli/Commands/AddCommand.cs | Update issue link in comment |
| src/Aspire.Cli/Agents/CommonAgentApplicators.cs | Update Learn link reference |
| src/Aspire.AppHost.Sdk/SDK/Sdk.in.targets | Update issue link in comment |
| playground/orleans/Orleans.AppHost/Program.cs | Update issue link in comment |
| playground/cdk/CdkSample.AppHost/sql-roles.module.bicep | Update issue URL in script content |
| playground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicep | Update issue URL in script content |
| playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep | Update issue URL in script content |
| playground/README.md | Update samples repo link |
| playground/ParameterEndToEnd/ParameterEndToEnd.AppHost/AppHost.cs | Update hyperlink to repo |
| extension/package.json | Update repo/issues URLs |
| extension/README.md | Update issue links to microsoft/aspire |
| eng/scripts/get-cli-e2e-recording.sh | Update default REPO |
| eng/scripts/get-cli-e2e-recording.ps1 | Update default Repo |
| eng/scripts/get-aspire-cli.sh | Update issue URLs in errors |
| eng/scripts/get-aspire-cli.ps1 | Update issue URL in error |
| eng/scripts/get-aspire-cli-pr.sh | Update default repo + URLs/docs |
| eng/scripts/README.md | Update raw script URLs + defaults |
| eng/pipelines/templates/BuildAndTest.yml | Update issue link in comment |
| eng/pipelines/release-publish-nuget.yml | Update repo/service-connection references |
| eng/pipelines/README.md | Update repo name reference |
| eng/Signing.props | Update issue link in comment |
| docs/unquarantine-policy.md | Update meta-issue link |
| docs/specs/polyglot-apphost.md | Update clone URL |
| docs/specs/polyglot-apphost-testing.md | Update issue link |
| docs/specs/dashboard-http-api.md | Update related issue/PR links |
| docs/specs/bundle.md | Update releases URL |
| docs/specs/appmodel.md | Update source link |
| docs/release-process.md | Update repo name + releases/service-connection refs |
| docs/quarantined-tests.md | Update QuarantinedTest example link |
| docs/machine-requirements.md | Update commit link |
| docs/dogfooding-pull-requests.md | Update defaults + raw script URLs |
| README.md | Update badges + samples repo link |
| Directory.Build.props | Update PackageProjectUrl + issue links in comments |
| AGENTS.md | Update issue/PR command examples to microsoft/aspire |
| .github/workflows/update-github-models.yml | Update owner guard |
| .github/workflows/update-dependencies.yml | Update owner guard |
| .github/workflows/update-ai-foundry-models.yml | Update owner guard |
| .github/workflows/tests.yml | Update owner guard |
| .github/workflows/tests-quarantine.yml | Update issue link in comment |
| .github/workflows/tests-outerloop.yml | Update issue link in comment |
| .github/workflows/specialized-test-runner.yml | Update owner guards |
| .github/workflows/reproduce-flaky-tests.yml | Update gh workflow invocation example |
| .github/workflows/release-github-tasks.yml | Update Learn + issues links |
| .github/workflows/refresh-manifests.yml | Update owner guard |
| .github/workflows/pr-review-needed.yml | Update owner guard |
| .github/workflows/pr-docs-hook.yml | Update owner guard + issue/PR text |
| .github/workflows/markdownlint.yml | Update owner guard |
| .github/workflows/locker.yml | Update owner guard |
| .github/workflows/labeler-predict-pulls.yml | Update owner check |
| .github/workflows/labeler-predict-issues.yml | Update owner check |
| .github/workflows/labeler-cache-retention.yml | Update owner check |
| .github/workflows/generate-ats-diffs.yml | Update owner guard |
| .github/workflows/generate-api-diffs.yml | Update owner guard |
| .github/workflows/dogfood-comment.yml | Update owner guard + raw script URLs |
| .github/workflows/deployment-tests.yml | Update owner guards + team mention |
| .github/workflows/deployment-test-command.yml | Update owner guard |
| .github/workflows/deployment-cleanup.yml | Update owner guard |
| .github/workflows/copilot-setup-steps.yml | Update owner-based runner selection |
| .github/workflows/cli-e2e-recording-comment.yml | Update owner guard |
| .github/workflows/ci.yml | Update owner guards |
| .github/workflows/backmerge-release.yml | Update owner guard |
| .github/workflows/auto-rerun-transient-ci-failures.yml | Update owner guard |
| .github/workflows/apply-test-attributes.yml | Update repository check |
| .github/workflows/README.md | Update command examples to microsoft/aspire |
| .github/skills/update-container-images/SKILL.md | Update repo references in skill docs |
| .github/skills/test-management/SKILL.md | Update repo references in skill docs |
| .github/skills/pr-testing/SKILL.md | Update repo references in skill docs |
| .github/skills/dependency-update/SKILL.md | Update repo references in skill docs |
| .github/skills/cli-e2e-testing/SKILL.md | Update repo references in skill docs |
| .github/skills/ci-test-failures/SKILL.md | Update repo references in skill docs |
| .github/instructions/hosting-readme.instructions.md | Update repo link in template instructions |
| .github/instructions/client-readme.instructions.md | Update repo links in template instructions |
| .github/ISSUE_TEMPLATE/config.yml | Update discussions link |
| .github/ISSUE_TEMPLATE/40_blocking_clean_ci.yml | Update issues link in template |
| .github/ISSUE_TEMPLATE/20_feature-request.yml | Update issues link in template |
| .github/ISSUE_TEMPLATE/10_bug_report.yml | Update discussions/issues links in template |
| ```bash | ||
| # 1. Check failed jobs on a PR | ||
| gh pr checks 14105 --repo dotnet/aspire 2>&1 | Where-Object { $_ -match "fail" } | ||
| gh pr checks 14105 --repo microsoft/aspire 2>&1 | Where-Object { $_ -match "fail" } | ||
|
|
||
| # 2. Get the run ID | ||
| $runId = gh run list --repo dotnet/aspire --branch davidfowl/my-branch --limit 1 --json databaseId --jq '.[0].databaseId' | ||
| $runId = gh run list --repo microsoft/aspire --branch davidfowl/my-branch --limit 1 --json databaseId --jq '.[0].databaseId' | ||
|
|
There was a problem hiding this comment.
This fenced block is labeled as bash, but several commands shown here (e.g., Where-Object, $runId = ..., Get-Content, Select-String) are PowerShell-specific. This is likely to confuse readers and copy/paste usage. Consider changing the code fence to powershell (or split into separate Bash and PowerShell examples with appropriate equivalents).
| if: ${{ github.repository_owner == 'microsoft' }} | ||
| outputs: | ||
| skip_workflow: ${{ (steps.check_for_changes.outputs.no_changes == 'true' || steps.check_for_changes.outputs.only_changed == 'true') && 'true' || 'false' }} | ||
| VERSION_SUFFIX_OVERRIDE: ${{ steps.compute_version_suffix.outputs.VERSION_SUFFIX_OVERRIDE }} |
There was a problem hiding this comment.
PR description says all dotnet/aspire repo references were updated, but there are still occurrences in the repository (e.g., custom-instructions/repo/.github/instructions/client-readme.instructions.md and custom-instructions/repo/.github/instructions/hosting-readme.instructions.md). Either update those remaining references too or clarify in the PR description which paths were intentionally excluded from the sweep.
| <!-- DefaultDotnetIconFullPath is only needed for the ServiceDisovery packages. The property can be removed when these libraries move. See https://github.com/microsoft/aspire/issues/170 --> | ||
| <DefaultDotnetIconFullPath>$(PackageIconFullPath)</DefaultDotnetIconFullPath> |
There was a problem hiding this comment.
The comment says "ServiceDisovery" which appears to be a typo. Please correct it to "ServiceDiscovery" to avoid propagating the misspelling in repo-wide guidance/comments.
The microsoft org disables GITHUB_TOKEN from creating PRs. This updates all 10 workflows that create PRs to use a GitHub App installation token (via actions/create-github-app-token) instead. - 9 workflows: add app token step, pass to existing PR creation logic - backport: rewrite locally (arcade reusable workflow doesn't accept custom tokens), filed dotnet/arcade#16585 for upstream support - release-github-tasks: also fix head: -> branch: bug in PR creation Replicates changes from microsoft/aspire-internal-reorg-temp#10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| - cron: '0 2 * * *' # Daily at 02:00 UTC | ||
|
|
||
| # TEMPORARILY DISABLED pull_request trigger due to #12143 (disk space issues): https://github.com/dotnet/aspire/issues/12143 | ||
| # TEMPORARILY DISABLED pull_request trigger due to #12143 (disk space issues): https://github.com/microsoft/aspire/issues/12143 |
There was a problem hiding this comment.
@radical - this issue is closed. Can this be reenabled? Or remove the link and update the comment with why it is disabled.
| } | ||
| ] | ||
| scriptContent: '\$sqlServerFqdn = "\$env:DBSERVER"\r\n\$sqlDatabaseName = "\$env:DBNAME"\r\n\$principalName = "\$env:PRINCIPALNAME"\r\n\$id = "\$env:ID"\r\n\r\n# Install SqlServer module - using specific version to avoid breaking changes in 22.4.5.1 (see https://github.com/dotnet/aspire/issues/9926)\r\nInstall-Module -Name SqlServer -RequiredVersion 22.3.0 -Force -AllowClobber -Scope CurrentUser\r\nImport-Module SqlServer\r\n\r\n\$sqlCmd = @"\r\nDECLARE @name SYSNAME = \'\$principalName\';\r\nDECLARE @id UNIQUEIDENTIFIER = \'\$id\';\r\n\r\n-- Convert the guid to the right type\r\nDECLARE @castId NVARCHAR(MAX) = CONVERT(VARCHAR(MAX), CONVERT (VARBINARY(16), @id), 1);\r\n\r\n-- Construct command: CREATE USER [@name] WITH SID = @castId, TYPE = E;\r\nDECLARE @cmd NVARCHAR(MAX) = N\'CREATE USER [\' + @name + \'] WITH SID = \' + @castId + \', TYPE = E;\'\r\nEXEC (@cmd);\r\n\r\n-- Assign roles to the new user\r\nDECLARE @role1 NVARCHAR(MAX) = N\'ALTER ROLE db_owner ADD MEMBER [\' + @name + \']\';\r\nEXEC (@role1);\r\n\r\n"@\r\n# Note: the string terminator must not have whitespace before it, therefore it is not indented.\r\n\r\nWrite-Host \$sqlCmd\r\n\r\n\$connectionString = "Server=tcp:\${sqlServerFqdn},1433;Initial Catalog=\${sqlDatabaseName};Authentication=Active Directory Default;"\r\n\r\n\$maxRetries = 5\r\n\$retryDelay = 60\r\n\$attempt = 0\r\n\$success = \$false\r\n\r\nwhile (-not \$success -and \$attempt -lt \$maxRetries) {\r\n \$attempt++\r\n Write-Host "Attempt \$attempt of \$maxRetries..."\r\n try {\r\n Invoke-Sqlcmd -ConnectionString \$connectionString -Query \$sqlCmd\r\n \$success = \$true\r\n Write-Host "SQL command succeeded on attempt \$attempt."\r\n } catch {\r\n Write-Host "Attempt \$attempt failed: \$_"\r\n if (\$attempt -lt \$maxRetries) {\r\n Write-Host "Retrying in \$retryDelay seconds..."\r\n Start-Sleep -Seconds \$retryDelay\r\n } else {\r\n throw\r\n }\r\n }\r\n}' | ||
| scriptContent: '\$sqlServerFqdn = "\$env:DBSERVER"\r\n\$sqlDatabaseName = "\$env:DBNAME"\r\n\$principalName = "\$env:PRINCIPALNAME"\r\n\$id = "\$env:ID"\r\n\r\n# Install SqlServer module - using specific version to avoid breaking changes in 22.4.5.1 (see https://github.com/microsoft/aspire/issues/9926)\r\nInstall-Module -Name SqlServer -RequiredVersion 22.3.0 -Force -AllowClobber -Scope CurrentUser\r\nImport-Module SqlServer\r\n\r\n\$sqlCmd = @"\r\nDECLARE @name SYSNAME = \'\$principalName\';\r\nDECLARE @id UNIQUEIDENTIFIER = \'\$id\';\r\n\r\n-- Convert the guid to the right type\r\nDECLARE @castId NVARCHAR(MAX) = CONVERT(VARCHAR(MAX), CONVERT (VARBINARY(16), @id), 1);\r\n\r\n-- Construct command: CREATE USER [@name] WITH SID = @castId, TYPE = E;\r\nDECLARE @cmd NVARCHAR(MAX) = N\'CREATE USER [\' + @name + \'] WITH SID = \' + @castId + \', TYPE = E;\'\r\nEXEC (@cmd);\r\n\r\n-- Assign roles to the new user\r\nDECLARE @role1 NVARCHAR(MAX) = N\'ALTER ROLE db_owner ADD MEMBER [\' + @name + \']\';\r\nEXEC (@role1);\r\n\r\n"@\r\n# Note: the string terminator must not have whitespace before it, therefore it is not indented.\r\n\r\nWrite-Host \$sqlCmd\r\n\r\n\$connectionString = "Server=tcp:\${sqlServerFqdn},1433;Initial Catalog=\${sqlDatabaseName};Authentication=Active Directory Default;"\r\n\r\n\$maxRetries = 5\r\n\$retryDelay = 60\r\n\$attempt = 0\r\n\$success = \$false\r\n\r\nwhile (-not \$success -and \$attempt -lt \$maxRetries) {\r\n \$attempt++\r\n Write-Host "Attempt \$attempt of \$maxRetries..."\r\n try {\r\n Invoke-Sqlcmd -ConnectionString \$connectionString -Query \$sqlCmd\r\n \$success = \$true\r\n Write-Host "SQL command succeeded on attempt \$attempt."\r\n } catch {\r\n Write-Host "Attempt \$attempt failed: \$_"\r\n if (\$attempt -lt \$maxRetries) {\r\n Write-Host "Retrying in \$retryDelay seconds..."\r\n Start-Sleep -Seconds \$retryDelay\r\n } else {\r\n throw\r\n }\r\n }\r\n}' |
There was a problem hiding this comment.
What is the update here? I don't expect this to change.
There was a problem hiding this comment.
There is a link an issue in this line (valid, though unnecessary, but like lots of changes in this PR)
| $id = "$env:ID" | ||
|
|
||
| # Install SqlServer module - using specific version to avoid breaking changes in 22.4.5.1 (see https://github.com/dotnet/aspire/issues/9926) | ||
| # Install SqlServer module - using specific version to avoid breaking changes in 22.4.5.1 (see https://github.com/microsoft/aspire/issues/9926) |
There was a problem hiding this comment.
oh this is the change in the bicep in the playground app
These are generated files that should not be modified directly. The dotnet/aspire issue URLs embedded in the SQL deployment scripts within these bicep files are correct as-is. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Merging to unblock other CIs |
|
/backport to release/13.2 |
1 similar comment
|
/backport to release/13.2 |
|
Started backporting to |
|
@joperezr backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Update all dotnet/aspire references to microsoft/aspire
Using index info to reconstruct a base tree...
M .github/skills/dependency-update/SKILL.md
A .github/skills/fix-flaky-test/SKILL.md
M .github/workflows/README.md
A .github/workflows/backmerge-release.yml
M .github/workflows/ci.yml
M .github/workflows/cli-e2e-recording-comment.yml
M .github/workflows/copilot-setup-steps.yml
A .github/workflows/reproduce-flaky-tests.yml
M AGENTS.md
A docs/unquarantine-policy.md
M eng/pipelines/release-publish-nuget.yml
M eng/scripts/get-aspire-cli.ps1
M eng/scripts/get-aspire-cli.sh
M extension/README.md
M extension/package.json
M playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep
M playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep
M playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
M playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
M src/Aspire.Cli/Configuration/AspireConfigFile.cs
M src/Aspire.Cli/Interaction/ConsoleInteractionService.cs
M src/Aspire.Cli/Program.cs
M src/Aspire.Cli/Projects/GuestAppHostProject.cs
M src/Aspire.Cli/Projects/ProjectLocator.cs
M src/Aspire.Cli/Utils/ConfigurationHelper.cs
M src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs
M src/Aspire.Hosting/Dcp/DcpExecutor.cs
M tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs
M tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs
M tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2ETestHelpers.cs
M tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs
M tests/Aspire.Hosting.Docker.Tests/DockerComposeTests.cs
M tests/Aspire.Hosting.Python.Tests/AddPythonAppTests.cs
M tests/Aspire.Hosting.Tests/ContainerTunnelTests.cs
M tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs
M tests/Aspire.Hosting.Tests/Pipelines/DistributedApplicationPipelineTests.cs
M tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs
M tests/Aspire.Hosting.Yarp.Tests/YarpFunctionalTests.cs
M tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj
M tests/Shared/Hex1bTestHelpers.cs
Falling back to patching base and 3-way merge...
Auto-merging .github/skills/dependency-update/SKILL.md
CONFLICT (modify/delete): .github/skills/fix-flaky-test/SKILL.md deleted in HEAD and modified in Update all dotnet/aspire references to microsoft/aspire. Version Update all dotnet/aspire references to microsoft/aspire of .github/skills/fix-flaky-test/SKILL.md left in tree.
Auto-merging .github/workflows/README.md
CONFLICT (modify/delete): .github/workflows/backmerge-release.yml deleted in HEAD and modified in Update all dotnet/aspire references to microsoft/aspire. Version Update all dotnet/aspire references to microsoft/aspire of .github/workflows/backmerge-release.yml left in tree.
Auto-merging .github/workflows/ci.yml
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
Auto-merging .github/workflows/cli-e2e-recording-comment.yml
CONFLICT (content): Merge conflict in .github/workflows/cli-e2e-recording-comment.yml
Auto-merging .github/workflows/copilot-setup-steps.yml
CONFLICT (content): Merge conflict in .github/workflows/copilot-setup-steps.yml
CONFLICT (modify/delete): .github/workflows/reproduce-flaky-tests.yml deleted in HEAD and modified in Update all dotnet/aspire references to microsoft/aspire. Version Update all dotnet/aspire references to microsoft/aspire of .github/workflows/reproduce-flaky-tests.yml left in tree.
Auto-merging AGENTS.md
CONFLICT (modify/delete): docs/unquarantine-policy.md deleted in HEAD and modified in Update all dotnet/aspire references to microsoft/aspire. Version Update all dotnet/aspire references to microsoft/aspire of docs/unquarantine-policy.md left in tree.
Auto-merging eng/pipelines/release-publish-nuget.yml
Auto-merging eng/scripts/get-aspire-cli.ps1
Auto-merging eng/scripts/get-aspire-cli.sh
Auto-merging extension/README.md
Auto-merging extension/package.json
Auto-merging playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep
CONFLICT (content): Merge conflict in playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep
Auto-merging playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep
CONFLICT (content): Merge conflict in playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep
Auto-merging playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
CONFLICT (content): Merge conflict in playground/bicep/BicepSample.AppHost/sql-roles.module.bicep
Auto-merging playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
CONFLICT (content): Merge conflict in playground/cdk/CdkSample.AppHost/sql-roles.module.bicep
Auto-merging src/Aspire.Cli/Configuration/AspireConfigFile.cs
Auto-merging src/Aspire.Cli/Interaction/ConsoleInteractionService.cs
Auto-merging src/Aspire.Cli/Program.cs
Auto-merging src/Aspire.Cli/Projects/GuestAppHostProject.cs
CONFLICT (content): Merge conflict in src/Aspire.Cli/Projects/GuestAppHostProject.cs
Auto-merging src/Aspire.Cli/Projects/ProjectLocator.cs
Auto-merging src/Aspire.Cli/Utils/ConfigurationHelper.cs
Auto-merging src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs
Auto-merging src/Aspire.Hosting/Dcp/DcpExecutor.cs
Auto-merging tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs
Auto-merging tests/Aspire.Cli.Tests/Interaction/ConsoleInteractionServiceTests.cs
Auto-merging tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2ETestHelpers.cs
CONFLICT (content): Merge conflict in tests/Aspire.Deployment.EndToEnd.Tests/Helpers/DeploymentE2ETestHelpers.cs
Auto-merging tests/Aspire.Hosting.Azure.Tests/AzureCosmosDBEmulatorFunctionalTests.cs
Auto-merging tests/Aspire.Hosting.Docker.Tests/DockerComposeTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Hosting.Docker.Tests/DockerComposeTests.cs
Auto-merging tests/Aspire.Hosting.Python.Tests/AddPythonAppTests.cs
Auto-merging tests/Aspire.Hosting.Tests/ContainerTunnelTests.cs
CONFLICT (content): Merge conflict in tests/Aspire.Hosting.Tests/ContainerTunnelTests.cs
Auto-merging tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs
Auto-merging tests/Aspire.Hosting.Tests/Pipelines/DistributedApplicationPipelineTests.cs
Auto-merging tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs
Auto-merging tests/Aspire.Hosting.Yarp.Tests/YarpFunctionalTests.cs
Auto-merging tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj
Auto-merging tests/Shared/Hex1bTestHelpers.cs
CONFLICT (content): Merge conflict in tests/Shared/Hex1bTestHelpers.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update all dotnet/aspire references to microsoft/aspire
Error: The process '/usr/bin/git' failed with exit code 128 |
The bicep files (both playground modules and test snapshots) contain GitHub issue URLs that need to point to microsoft/aspire. These were incorrectly reverted in microsoft#15452. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@copilot backport this PR to target release/13.2 |
1 similar comment
|
@copilot backport this PR to target release/13.2 |
Description
All GitHub Actions workflow files contained owner guards checking for
github.repository_owner == 'dotnet'. Since this repo is now undermicrosoft/aspire, these guards evaluated tofalseand silently skipped every CI job on PRs and pushes.This PR updates:
repository_owner == 'dotnet'→repository_owner == 'microsoft'dotnet/aspirerepository references →microsoft/aspireacross 288 files (workflows, scripts, tests, READMEs, source code, templates, and documentation)SigstoreNpmProvenanceCheckerTestsexpectedOwner to match the updated URLaka.msshort links pointing todotnet/aspireare preserved as those are external redirects we don't control.Replicates the changes from https://github.com/microsoft/aspire-internal-reorg-temp/pull/7.
Checklist