Fix bicep files: update dotnet/aspire references to microsoft/aspire#15458
Open
joperezr wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix bicep files: update dotnet/aspire references to microsoft/aspire#15458joperezr wants to merge 2 commits intomicrosoft:mainfrom
joperezr wants to merge 2 commits intomicrosoft:mainfrom
Conversation
The bicep files (both playground modules and test snapshots) contain GitHub issue URLs that need to point to microsoft/aspire. These were incorrectly reverted in microsoft#15452. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15458Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15458" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Bicep modules and verified snapshot files so embedded GitHub issue URLs reference microsoft/aspire (aligning snapshots with current source output).
Changes:
- Rewrites embedded issue links from
https://github.com/dotnet/aspire/...tohttps://github.com/microsoft/aspire/...inside deployment script content. - Updates verified
.verified.bicepsnapshots to match the expected output. - (Incidental) Normalizes the first-line encoding/formatting in several snapshot files (BOM/indentation).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/Snapshots/RoleAssignmentTests.SqlSupport.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_SubnetBeforePrivateEndpoint.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_StorageBeforePrivateEndpoint.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_ExplicitSubnet_AutoCreatesStorage.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_ExplicitStorage_AutoCreatesSubnet.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_BothExplicitSubnetAndStorage.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureSqlDeploymentScriptTests.SqlWithPrivateEndpoint_AutoCreatesBothSubnetAndStorage.verified.bicep | Updates embedded issue URL; also changes first-line BOM/indentation. |
| playground/cdk/CdkSample.AppHost/sql-roles.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/bicep/BicepSample.AppHost/sql-roles.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep | Updates embedded issue URL in PowerShell script content. |
| playground/AzureVirtualNetworkEndToEnd/AzureVirtualNetworkEndToEnd.AppHost/api-roles-sql.module.bicep | Updates embedded issue URL in PowerShell script content. |
| @@ -1,4 +1,4 @@ | |||
| @description('The location for the resource(s) to be deployed.') | |||
| @description('The location for the resource(s) to be deployed.') | |||
There was a problem hiding this comment.
This PR is described as updating dotnet/aspire URLs to microsoft/aspire, but this snapshot also changes the file’s first-line formatting/encoding (the previous version appears to have included a BOM and different indentation). This adds unrelated churn and may cause platform/tooling differences in snapshot comparisons. Recommendation (moderate): regenerate snapshots using the standard snapshot tooling (or restore the original encoding/whitespace) so the diff is limited to the intended URL changes.
The microsoft org does not have macos-latest runners available for this repo yet, causing macOS jobs to hang indefinitely in queued state. Disabled build_cli_archive_macos and tests_requires_nugets_macos jobs, removed them from the results gate dependencies and failure conditions, and commented out the macOS artifact download step. Each change is marked with a comment linking to the tracking issue. Tracking issue: microsoft#15461 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bicep files (both playground modules and test verified snapshots) contain GitHub issue URLs that need to point to
microsoft/aspire. These were incorrectly reverted in #15452 based on the assumption that they were generated files that shouldn't be touched, but the test snapshots need to match the source code which now referencesmicrosoft/aspire.Updates 14 bicep files:
*.module.bicepfiles*.verified.bicepsnapshot filesChecklist