-
Notifications
You must be signed in to change notification settings - Fork 953
Add pinning to Dashboard run history #18925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| ::deep .aspire-menu-secondary-action { | ||
| opacity: 0; | ||
| visibility: hidden; | ||
| padding-left: 8px; | ||
| } | ||
|
|
||
| ::deep .aspire-menu-secondary-action::part(control) { | ||
| background-color: transparent; | ||
| } | ||
|
|
||
| ::deep .aspire-menu-secondary-action:hover::part(control) { | ||
| background-color: var(--neutral-fill-secondary-hover); | ||
| } | ||
|
|
||
| fluent-menu-item:hover > span[slot="end"] ::deep .aspire-menu-secondary-action, | ||
| fluent-menu-item:focus-within > span[slot="end"] ::deep .aspire-menu-secondary-action, | ||
| ::deep .aspire-menu-secondary-action.selected { | ||
| opacity: 1; | ||
| visibility: visible; | ||
| } | ||
|
|
||
| @media (hover: none) { | ||
| fluent-menu-item > span[slot="end"] ::deep .aspire-menu-secondary-action { | ||
| opacity: 1; | ||
| visibility: visible; | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still reproduces at
65b4a0aafter the attempted fix from my prior review: pinning leaves Live and another run checked, and Tab exits the menu without ever reaching the pin action. Stoppingkeydownpropagation on the wrapper does not make the nested button part of FAST'smenuitemradiokeyboard/selection model. I think this needs a menu structure with one actionable control per item, or another pattern that does not nest the pin control inside the radio item.