Skip to content

Hide Orleans provider annotation - #18975

Merged
Sébastien Ros (sebastienros) merged 1 commit into
mainfrom
sebros/hide-orleans-annotation
Aug 4, 2026
Merged

Hide Orleans provider annotation#18975
Sébastien Ros (sebastienros) merged 1 commit into
mainfrom
sebros/hide-orleans-annotation

Conversation

@sebastienros

Copy link
Copy Markdown
Contributor

Description

Keeps OrleansProviderTypeAnnotation as internal implementation plumbing while preserving WithOrleansProviderType as the supported public builder API.

Tests now validate provider replacement through the resulting Orleans configuration rather than constructing or inspecting the internal annotation.

Addresses #17846 (comment).

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Keep OrleansProviderTypeAnnotation as internal implementation plumbing and test provider overrides through the public builder API.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 25b57d9a-ff4a-4252-a7fc-d28d4fdde90f
Copilot AI review requested due to automatic review settings August 3, 2026 23:11
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18975

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18975"

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

1 / 100 test projects · 2 jobs, from 2 changed files.

Selected test projects (1 / 100)

Aspire.Hosting.Orleans.Tests

Selected jobs (2)

extension-e2e, typescript-api-compat


How these were chosen — grouped by what changed

🔧 src/Aspire.Hosting.Orleans/OrleansProviderTypeAnnotation.cs (changed source)
1 directly: Aspire.Hosting.Orleans.Tests

🧪 tests/Aspire.Hosting.Orleans.Tests/OrleansProviderTypeTests.cs (changed test)
1 directly: Aspire.Hosting.Orleans.Tests

Job reasons

Job Triggered by
extension-e2e src/Aspire.Hosting.Orleans/OrleansProviderTypeAnnotation.cs
• affected project Aspire.Hosting.Orleans
typescript-api-compat affected project Aspire.Hosting.Orleans

Selection computed for commit 0556c77.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hides Orleans provider annotation plumbing while preserving the public builder API.

Changes:

  • Makes OrleansProviderTypeAnnotation internal.
  • Updates tests to validate generated Orleans configuration instead of internal annotations.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Aspire.Hosting.Orleans/OrleansProviderTypeAnnotation.cs Restricts annotation visibility.
tests/Aspire.Hosting.Orleans.Tests/OrleansProviderTypeTests.cs Removes tests coupled to annotation internals.

@sebastienros
Sébastien Ros (sebastienros) marked this pull request as draft August 3, 2026 23:18
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@sebastienros

Copy link
Copy Markdown
Contributor Author

cc Lars Hanisch (@flensrocker)

@sebastienros
Sébastien Ros (sebastienros) merged commit afb4351 into main Aug 4, 2026
679 of 682 checks passed
@sebastienros
Sébastien Ros (sebastienros) deleted the sebros/hide-orleans-annotation branch August 4, 2026 04:23
@github-actions github-actions Bot added this to the 13.5 milestone Aug 4, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

docs_optional → internal_refactor

No signals triggered (signal_count = 0).

The PR hides OrleansProviderTypeAnnotation as an internal type while keeping WithOrleansProviderType as the public API. The PR checklist confirms no public API was added. Tests were updated to validate behavior through Orleans configuration rather than inspecting the internal annotation. All changed files match the internal_refactor allowlist category — a src/ change that removes a type from public surface with no new or changed public types, methods, or options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants