Fix Kubernetes persistent volume ATS export names - #18979
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c05591-5ad7-4d10-b6b4-40bf8337f17f
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18979Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18979" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Corrects Kubernetes persistent-volume ATS export names and validates generated SDK discoverability across supported polyglot AppHosts.
Changes:
- Renames parameterized storage-class and capacity exports.
- Adds TypeScript, Python, Go, and Java compile coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Hosting.Kubernetes/KubernetesPersistentVolumeExtensions.cs |
Corrects ATS export names. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/TypeScript/apphost.mts |
Exercises both overload forms. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Python/apphost.py |
Exercises both overload forms. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Go/apphost.go |
Exercises both overload forms. |
tests/PolyglotAppHosts/Aspire.Hosting.Kubernetes/Java/AppHost.java |
Exercises both overload forms. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 65c05591-5ad7-4d10-b6b4-40bf8337f17f
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 3 / 100 test projects · 4 jobs, from 6 changed files. Selected test projects (3 / 100)
Selected jobs (4)
How these were chosen — grouped by what changed🔧 🔧 Job reasons
Selection computed for commit |
|
Pull request created: #1450
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1450 targeting Updated the TypeScript configuration-methods table in Note This draft PR needs human review before merging. |
Description
Parameterized Kubernetes persistent-volume configuration should be discoverable beside its literal counterpart in generated AppHost SDKs. This changes the ATS export names from
withPvStorageClassParamandwithPvCapacityParamto the parallelwithStorageClassParamandwithCapacityParamnames.KubernetesPersistentVolumeResourceis now explicitly exported to ATS, matching the established pattern for Kubernetes Gateway, Ingress, NodePool, HelmChart, and cert-manager resources. The Kubernetes polyglot AppHosts exercise the resource-level API plus both literal and parameterized persistent-volume configuration in TypeScript, Python, Go, and Java.User-facing usage
C# AppHost:
TypeScript AppHost:
Validation included building
Aspire.Hosting.Kubernetes, regenerating each affected polyglot SDK with the repository CLI, and compiling the TypeScript, Python, Go, and Java Kubernetes AppHosts.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?