Show status while preparing dashboard bundle - #18985
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 18985Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 18985" |
There was a problem hiding this comment.
Pull request overview
Adds delayed feedback while aspire dashboard run prepares its bundle, keeping fast cached startup quiet while making slower extraction visible.
Changes:
- Adds a 200 ms grace period before showing
Preparing dashboard bits.... - Adds localized resource entries for the new status.
- Adds focused tests and bundle-service test hooks for fast and delayed acquisition.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Cli/Commands/DashboardRunCommand.cs |
Adds delayed bundle-preparation status handling. |
src/Aspire.Cli/Resources/DashboardCommandStrings.resx |
Defines the new status text. |
src/Aspire.Cli/Resources/DashboardCommandStrings.Designer.cs |
Exposes the generated resource property. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.cs.xlf |
Adds the Czech localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.de.xlf |
Adds the German localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.es.xlf |
Adds the Spanish localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.fr.xlf |
Adds the French localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.it.xlf |
Adds the Italian localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.ja.xlf |
Adds the Japanese localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.ko.xlf |
Adds the Korean localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.pl.xlf |
Adds the Polish localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.pt-BR.xlf |
Adds the Brazilian Portuguese localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.ru.xlf |
Adds the Russian localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.tr.xlf |
Adds the Turkish localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.zh-Hans.xlf |
Adds the Simplified Chinese localization unit. |
src/Aspire.Cli/Resources/xlf/DashboardCommandStrings.zh-Hant.xlf |
Adds the Traditional Chinese localization unit. |
tests/Aspire.Cli.Tests/Commands/DashboardRunCommandTests.cs |
Tests quiet fast acquisition and visible delayed acquisition. |
tests/Aspire.Cli.Tests/Utils/CliTestHelper.cs |
Adds a callback hook for controlling bundle acquisition in tests. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/DashboardCommandStrings.Designer.cs: Generated file
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. 2 / 100 test projects · 5 jobs, from 18 changed files. Selected test projects (2 / 100)
Selected jobs (5)
How these were chosen — grouped by what changed📦 affected project 🧪 🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
bbb47ac
into
main
|
Documentation was required for the See the workflow run for details: https://github.com/microsoft/aspire/actions/runs/31028135749 |
Description
aspire dashboard runcould appear idle while the CLI prepared or extracted its bundle. The existingStarting dashboard...status is intentionally scoped to launching the dashboard process, so this change adds a separate delayed status for bundle preparation.Bundle acquisition now gets a 200 ms grace period. Typical cached acquisition remains quiet, while slower acquisition displays
Preparing dashboard bits...until the bundle is ready.User-facing usage
When bundle preparation takes longer than 200 ms, the CLI now shows:
Screenshots / Recordings
TODO: Run
aspire dashboard runwith uncached bundle extraction to capture the delayed preparation status.Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?