Support running the Aspire dashboard from tests by adamint · Pull Request #19135 · microsoft/aspire

Adam Ratzman (adamint) · 2026-08-07T15:11:01Z

Description

Adds first-class support for running the Aspire dashboard from inside a test, so a failing integration test can be inspected the same way a running app can.

#15575 originally asked for VS Code extension integration with DistributedApplicationTestingBuilder. Per the discussion on the issue, the extension approach has a chicken-and-egg problem — the backchannel cannot answer while the AppHost is stopped at a breakpoint — so this takes the alternative direction recorded there: let the test host run the dashboard itself.

var options = new DistributedApplicationTestingBuilderOptions
{
    EnableDashboard = true,
    // Keep a failing dependency alive long enough to look at it.
    DefaultWaitBehavior = WaitBehavior.WaitOnResourceUnavailable
};

var builder = await DistributedApplicationTestingBuilder.CreateAsync<Projects.MyAppHost>(options, []);
await using var app = await builder.BuildAsync();
await app.StartAsync();

// Paste this into a browser.
var loginUrl = await app.GetDashboardLoginUrlAsync();

What runs when the dashboard is enabled

The dashboard runs on authenticated loopback endpoints with dynamically assigned ports, interactivity off, and a freshly generated browser token per application. Those defaults are applied both before the builder is constructed (dashboard services and authentication are selected during construction and cannot be added afterwards) and again on the constructed builder, so an AppHost's own arguments, environment variables, or launch profile cannot quietly downgrade them. Settings that remain adjustable at runtime can still be overridden through the returned builder.

DistributedApplicationOptions.DisableDashboard = false was already the informal way to do this, so it is treated as equivalent to the new option and receives the same hardening. That also means the existing configureBuilder overloads remain a complete way to enable the dashboard alongside arbitrary builder customization.

Lifecycle fixes found along the way

Adding deterministic tests for the "released but still building" window surfaced pre-existing defects in DistributedApplicationFactory and the suspending builder:

BuildAsync awaited the released AppHost inline before rethrowing, so a cancelled build blocked until the AppHost finished — and never returned at all if it never finished. It now reclaims the late application on a background continuation and rethrows immediately.
An application that finished building after the factory was disposed was dropped on the floor: TrySetResult returned false and the DistributedApplication, its service provider, and its orchestrator processes stayed alive for the rest of the test process. It is now disposed at the point it arrives.
DisposeAsync's guard read _disposingCts.IsCancellationRequested, which is not atomic with OnDisposed(), so two concurrent disposers could both run teardown and race on StopAsync/DisposeAsync of the same application. It now claims disposal with Interlocked.Exchange.
ObjectDisposedException leaked the internal nested factory type name instead of IDistributedApplicationTestingBuilder.

Notes for reviewers

Aspire.Hosting now grants InternalsVisibleTo to Aspire.Hosting.Testing, which is a shipping package rather than a test project. It reuses the product's dashboard configuration keys, token generation, and login URL resolution instead of duplicating them. This required dropping the $(SharedDir) compile links from Aspire.Hosting.Testing.csproj, because compiling both copies produces CS0436. There is precedent — Aspire.Hosting.Kubernetes and Aspire.Hosting.Radius already hold the same grant. Everything consumed is internal, so there is no change to the shipped surface.
DashboardUrlsHelper now percent-encodes the browser token when composing the login URL. This is on the CLI's path as well as the new one. ValidateTokenMiddleware reads the token from Request.Query, which URL-decodes, so this is a correctness fix rather than a behavior change, but it is worth a second pair of eyes.
Dashboard endpoints are configured with an empty URL, not http://127.0.0.1:0. Blank is how the product spells "assign me a free port": ConfigureDefaultDashboardOptions normalizes it to null and DashboardEventHandlers then creates the endpoint with port: null. An explicit :0 parses to a literal fixed port and was only dynamic while DcpPublisher:RandomizePorts happened to stay true. Loopback binding is preserved because EndpointAnnotation.TargetHost defaults to localhost.
The browser token is supplied through the command line rather than in-memory configuration. DistributedApplicationBuilder resolves the token during construction and freezes it into AppHost:BrowserToken, so it must be visible before construction and there must be exactly one value. Command line also outranks an ambient ASPIRE_DASHBOARD_FRONTEND_BROWSERTOKEN, which on a CI agent would otherwise share one known token across every application running there.
Behavior change: enabling the dashboard normally flips the hosting default to WaitOnResourceUnavailable. The testing builder re-pins StopOnResourceUnavailable so an unattended run fails instead of hanging. This now also applies to the older DisableDashboard = false spelling. DefaultWaitBehavior is the opt-out.

Follow-ups deliberately not in this change

DashboardUrlsHelper lives under Backchannel/ and now carries a throwOnDashboardFailure flag to serve two callers. It belongs under src/Aspire.Hosting/Dashboard/ with the CLI adapting to it, rather than the other way round.
No environment-variable opt-in (for example ASPIRE_TESTING_ENABLE_DASHBOARD) and no automatic emission of the login URL to test output. Both would remove the edit-and-rebuild step from the debugging loop.
#15575 is labelled area-vscode-extension and nothing under extension/ changes here. This lands the primitive the extension would need; the editor-side half is still open. Worth noting that afscrome's breakpoint concern applies to an in-process dashboard too — stopping the test thread with default all-threads-stop also freezes the dashboard's Kestrel and SignalR threads.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

The dashboard is only reachable over loopback, requires a per-application browser token, and anonymous access is forced off through the highest-precedence configuration source. No token is written to logs. Worth confirming during review that forcing ASPIRE_ALLOW_UNSECURED_TRANSPORT for the test dashboard is acceptable.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ffeff87e-f284-434d-87d3-843e21a7aebb

Reuse the canonical dashboard URL path, enforce authenticated testing defaults, and preserve cancellation and disposal semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ffeff87e-f284-434d-87d3-843e21a7aebb

Lifecycle correctness: - BuildAsync no longer blocks on the released AppHost when the caller's token fires. It reclaims the late application on a background continuation and rethrows immediately, so cancellation is prompt even when the AppHost never finishes building. - DistributedApplicationFactory.OnBuiltCoreAsync disposes an application that arrives after the factory was disposed. Previously TrySetResult simply returned false and the built DistributedApplication, its service provider, and its orchestrator processes leaked for the lifetime of the test process. - DisposeAsync claims disposal with Interlocked.Exchange. The previous IsCancellationRequested read was not atomic with OnDisposed(), so concurrent disposers could both run teardown and race on the same application. - ObjectDisposedException now consistently reports IDistributedApplicationTestingBuilder rather than leaking the internal factory type name. Behavior: - DistributedApplicationOptions.DisableDashboard = false, the pre-existing spelling of "run the dashboard", now receives the same hardened testing defaults as the new EnableDashboard option instead of only one of them being hardened. - Dashboard endpoints are configured with an empty URL, which is how the product asks for a dynamically assigned port. The previous "http://127.0.0.1:0" parses to a literal fixed port 0 and was only dynamic while DcpPublisher:RandomizePorts stayed true. - A fresh browser token is generated per application and supplied through the command line, which has the highest precedence. Disabling anonymous access only closes the door if a credential exists, and an ambient ASPIRE_DASHBOARD_FRONTEND_BROWSERTOKEN would otherwise share one known token across every application on a CI agent. - DistributedApplicationTestingBuilderOptions.DefaultWaitBehavior lets a debugging session keep a stuck resource alive to inspect it, rather than always tearing the application down. Conventions: - Exception messages moved to Properties/Resources.resx with regenerated xlf, matching the rest of the file. - Commented the Aspire.Hosting InternalsVisibleTo grant, including why the shared file links had to be dropped. - Replaced vacuous Assert.NotNull-on-a-lambda assertions with assertions that exercise the overloads, and added coverage for per-application token isolation, DefaultWaitBehavior, publish-mode rejection through configureBuilder, and disposal of a late-arriving application. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f3f649b5-52c4-4eb5-8d74-c4744e79faf4

github-actions · 2026-08-07T15:11:39Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19135

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19135"

Copilot

Pull request overview

Adds first-class support for authenticated Aspire dashboards in integration tests and hardens testing-builder lifecycle behavior.

Changes:

Adds dashboard testing options and login URL retrieval.
Enforces secure, dynamic dashboard defaults.
Fixes cancellation/disposal races and adds lifecycle/dashboard tests.

Show a summary per file

File	Description
`tests/TestingAppHost1/TestingAppHost1.AppHost/TestingAppHostBuildProbe.cs`	Adds deterministic build lifecycle probe.
`tests/TestingAppHost1/TestingAppHost1.AppHost/Program.cs`	Supports dashboard and build test scenarios.
`tests/Aspire.Hosting.Testing.Tests/DashboardTestingBuilderTests.cs`	Tests dashboard configuration and lifecycle behavior.
`tests/Aspire.Hosting.Testing.Tests/DashboardLoginUrlTests.cs`	Tests dashboard URL and authentication behavior.
`src/Aspire.Hosting/Backchannel/DashboardUrlsHelper.cs`	Escapes tokens and preserves dashboard failures.
`src/Aspire.Hosting/Aspire.Hosting.csproj`	Grants testing package internal access.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.cs.xlf`	Updates Czech resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.de.xlf`	Updates German resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.es.xlf`	Updates Spanish resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.fr.xlf`	Updates French resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.it.xlf`	Updates Italian resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.ja.xlf`	Updates Japanese resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.ko.xlf`	Updates Korean resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.pl.xlf`	Updates Polish resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.pt-BR.xlf`	Updates Brazilian Portuguese resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.ru.xlf`	Updates Russian resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.tr.xlf`	Updates Turkish resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.zh-Hans.xlf`	Updates Simplified Chinese resources.
`src/Aspire.Hosting.Testing/Properties/xlf/Resources.zh-Hant.xlf`	Updates Traditional Chinese resources.
`src/Aspire.Hosting.Testing/Properties/Resources.resx`	Adds dashboard error messages.
`src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs`	Exposes generated resource accessors.
`src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilderOptions.cs`	Adds public dashboard testing options.
`src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs`	Configures dashboards and fixes build lifecycle handling.
`src/Aspire.Hosting.Testing/DistributedApplicationHostingTestingExtensions.cs`	Adds dashboard login URL API.
`src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs`	Fixes late-application and concurrent disposal handling.
`src/Aspire.Hosting.Testing/Aspire.Hosting.Testing.csproj`	Removes duplicated shared source links.

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (1)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:253

This existing public overload can now reject publish mode when configureBuilder enables the dashboard, but the new InvalidOperationException is absent from its XML documentation. Please document the condition as part of this behavior change.

    public static IDistributedApplicationTestingBuilder Create(string[] args, Action<DistributedApplicationOptions, HostApplicationBuilderSettings> configureBuilder)
        => CreateCore(args, testingOptions: null, configureBuilder);

Files reviewed: 25/26 changed files
Comments generated: 2
Review effort level: Balanced

github-actions · 2026-08-07T15:44:09Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-08-07T15:56:20Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-08-07T16:09:29Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Alex Crome (afscrome) · 2026-08-07T16:47:28Z

This overlaps slightly with #18746

Restrict the hardened dashboard testing defaults to the explicit DistributedApplicationTestingBuilderOptions.EnableDashboard opt-in. Treating DistributedApplicationOptions.DisableDashboard = false as an equivalent spelling changed behavior for every caller already using it: - The args rebuild read hostBuilderOptions.Args, which the factory has already populated, so arguments a configureBuilder callback assigned to applicationOptions.Args were dropped. DashboardIsNotAddedInPublishMode lost "--publisher manifest", ran in run mode, and saw a dashboard resource it asserted was absent. - The appended dashboard settings overrode the caller's own configuration. GetDashboardUrlsAsync_ReturnsBaseUrl_WhenDashboardAllowsAnonymousAccess asked for anonymous access and got a browser token instead. Also merge caller args instead of choosing one array, so the new opt-in appends to whatever the callback left in place. Build Aspire.Dashboard from Aspire.Hosting.Testing.Tests. The tests that start a real dashboard resolve it from the repo-wide AspireDashboardDir, which was empty in the Hosting.Testing CI leg, failing all eight of them. Add ConcurrentDisposeAsyncRunsTeardownOnce, covering the interlocked disposal claim in DistributedApplicationFactory.DisposeAsync. With the claim reverted to a cancellation-token read the test fails consistently; with the claim in place it passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (2)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:290

The PR description still says DistributedApplicationOptions.DisableDashboard = false is equivalent to the new option and receives the same hardening, but this code now explicitly preserves the older unhardened behavior (and the new tests assert that behavior). Please update the description and security notes so reviewers and users are not promised hardening on that existing path.

        // Only the explicit option turns on the hardened testing defaults below. Setting
        // DistributedApplicationOptions.DisableDashboard = false through the configureBuilder callback is the older,
        // already-shipped spelling of "run a dashboard", and it has to keep the behavior it shipped with: callers use
        // it to exercise dashboard behavior against configuration they chose themselves (fixed URLs, anonymous
        // access, an ambient browser token), and in publish mode it is simply ignored because no dashboard resource
        // is ever added. Treating it as equivalent to the option silently rewrote that configuration and turned
        // publish-mode callers into an InvalidOperationException.

src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs:510

A concurrent caller that loses this exchange returns from DisposeAsync immediately, potentially before the winner calls OnDisposed() and before any teardown completes. Consequently, awaiting DisposeAsync can report completion while the application is still running, and public factory operations can still pass the _disposingCts disposed check during that window. Store/share the winning disposal task (or completion source) so every concurrent caller awaits the same teardown rather than returning early.

        if (Interlocked.Exchange(ref _disposeClaimed, 1) == 1)
        {
            // Dispose already called.
            return;

Files reviewed: 26/27 changed files
Comments generated: 1
Review effort level: Balanced

github-actions · 2026-08-07T18:03:49Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-08-07T18:10:35Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-08-07T18:16:24Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Copilot

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (3)

src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs:507

The atomic disposal claim still leaves a publication race. DisposeAsync can observe _appTcs as incomplete, then OnBuiltCoreAsync can successfully publish the application before TrySetCanceled runs. The disposer then returns, OnBuiltCoreAsync does not reclaim the successfully published application, and every later disposer exits because this exchange already claimed disposal. Recheck the result of TrySetCanceled and fall through to teardown when publication won the race.

        if (Interlocked.Exchange(ref _disposeClaimed, 1) == 1)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:290

The PR description still says DistributedApplicationOptions.DisableDashboard = false is equivalent to the new option and receives the same hardening, but this code deliberately preserves its older, unhardened behavior. Update the description and security summary so reviewers and users are not told this existing opt-in gets protections that the implementation intentionally does not apply.

        // Only the explicit option turns on the hardened testing defaults below. Setting
        // DistributedApplicationOptions.DisableDashboard = false through the configureBuilder callback is the older,
        // already-shipped spelling of "run a dashboard", and it has to keep the behavior it shipped with: callers use
        // it to exercise dashboard behavior against configuration they chose themselves (fixed URLs, anonymous
        // access, an ambient browser token), and in publish mode it is simply ignored because no dashboard resource
        // is ever added. Treating it as equivalent to the option silently rewrote that configuration and turned
        // publish-mode callers into an InvalidOperationException.

tests/Aspire.Hosting.Testing.Tests/DashboardTestingBuilderTests.cs:391

The PR description promises that AppHost configuration cannot downgrade the authenticated dashboard defaults, while this test intentionally codifies that the AppHost can clear AppHost:BrowserToken, causing the dashboard to use unsecured frontend authentication. Since the escape hatch is intentional, update the description and security guarantee to document this exception.

    public async Task DashboardTestingDoesNotPinTheBrowserTokenAgainstTheAppHost(CreationSurface creationSurface)
    {
        // Anonymous access is settled while the builder is constructed and cannot be taken back, but the browser
        // token is only read out of AppHost:BrowserToken when DashboardOptions is first resolved, so an AppHost
        // that clears the key still gets a dashboard with no credential. That asymmetry is deliberate rather than

Files reviewed: 26/29 changed files
Comments generated: 1
Review effort level: Balanced

github-actions · 2026-08-07T19:50:07Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

github-actions · 2026-08-07T19:57:12Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Review asked for the generated browser token to be restored after the AppHost configures itself, so an AppHost clearing AppHost:BrowserToken could not downgrade the dashboard to Unsecured authentication. Pinning it onto DashboardOptions works, but it removes the only way to reach the anonymous dashboard path once EnableDashboard has appended its own arguments. Two tests in this PR rely on that escape hatch through the returned builder, and both fail with the token pinned: GetDashboardLoginUrlAsyncThrowsWhenDashboardAllowsAnonymousAccess and CanonicalDashboardLoginUrlEscapesBrowserToken. The state is also not silent. DashboardUrlsHelper reports HasBrowserToken false and GetDashboardLoginUrlAsync throws rather than returning an unauthenticated URL. Cover the boundary instead, so neither side of it can drift unnoticed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (1)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:291

The PR description still says DistributedApplicationOptions.DisableDashboard = false is equivalent to EnableDashboard and receives the same hardening/fail-fast wait behavior. This branch now explicitly excludes that older path, and the added tests verify that its fixed URLs and anonymous access remain unchanged. Please update the description and security/behavior notes so reviewers and release notes do not claim guarantees the implementation intentionally does not provide.

        return testingOptions?.EnableDashboard == true;

Files reviewed: 26/27 changed files
Comments generated: 0 new
Review effort level: Balanced

After a post-release cancellation, ReclaimApplicationInBackground awaited the shared application task and then disposed the factory unconditionally. The continuation state stayed ContinuationReleased, so a concurrent or retried BuildAsync kept waiting on that same task. When the application arrived both callers received it and the background continuation tore it down underneath the surviving one. Guard the continuation state and the outstanding build count together, so only the last caller to cancel reclaims the application, and reject later builds once it has been claimed rather than handing back an instance that is being disposed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (3)

src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs:507

The atomic claim prevents duplicate teardown, but every concurrent caller that loses the exchange now receives a completed ValueTask while the winning caller may still be awaiting shutdown and disposal. A caller can therefore continue cleanup while AppHost processes are still running. Cache the in-progress disposal task (or signal completion with a TaskCompletionSource) and have subsequent DisposeAsync calls await the same teardown.

        if (Interlocked.Exchange(ref _disposeClaimed, 1) == 1)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilderOptions.cs:46

This public documentation guarantees authenticated endpoints, but the implementation intentionally lets AppHost code clear AppHost:BrowserToken, which launches the dashboard with unsecured frontend authentication. Document that opt-out so callers do not rely on authentication as an invariant of EnableDashboard.

    /// When the dashboard runs, it listens on authenticated loopback endpoints using dynamically assigned ports so
    /// that concurrent test applications cannot collide or reach each other. Use
    /// <see cref="DistributedApplicationHostingTestingExtensions.GetDashboardLoginUrlAsync"/> to obtain an
    /// authenticated URL for the running dashboard.

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:291

The PR description still says DistributedApplicationOptions.DisableDashboard = false is equivalent to EnableDashboard and receives the same hardening and fail-fast wait behavior, but this condition explicitly excludes that existing spelling. The added tests also assert that its caller-selected anonymous/fixed-port configuration is preserved. Update the PR description and security/behavior notes to describe the implemented distinction.

        return testingOptions?.EnableDashboard == true;

Files reviewed: 26/27 changed files
Comments generated: 0 new
Review effort level: Balanced

DistributedApplicationBuilder freezes the generated browser token into AppHost:BrowserToken while the builder is constructed, but DashboardOptions does not read that key until the application starts. AppHost code runs between those two points, so it could blank the key and DashboardEventHandlers would then launch the dashboard with Unsecured frontend authentication, silently downgrading the authenticated default EnableDashboard promises. Keep the generated token in DashboardTestingState and put it back once the AppHost entry point has finished configuring. The guard mirrors the string.IsNullOrEmpty check DashboardEventHandlers itself applies, so a deliberately chosen non-empty token is left alone, and it runs before the caller sees the builder, so the documented escape hatch to the anonymous dashboard is unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Review details

Files not reviewed (1)

src/Aspire.Hosting.Testing/Properties/Resources.Designer.cs: Generated file

Suppressed comments (1)

src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:291

The PR description still says DisableDashboard = false is equivalent to EnableDashboard and receives the same hardening/default wait behavior, but this code now explicitly preserves the older behavior (also asserted by the new tests). Please update the description so it does not claim security and lifecycle behavior that this path no longer provides.

        return testingOptions?.EnableDashboard == true;

Files reviewed: 26/27 changed files
Comments generated: 0 new
Review effort level: Balanced

…575-testing-dashboard

Adam Ratzman and others added 4 commits August 7, 2026 01:43

Add dashboard support to testing builders

58017af

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ffeff87e-f284-434d-87d3-843e21a7aebb

Merge microsoft/main into adamint/feature-15575-testing-dashboard

e07a461

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ffeff87e-f284-434d-87d3-843e21a7aebb

Finish testing dashboard support

8ef74cd

Reuse the canonical dashboard URL path, enforce authenticated testing defaults, and preserve cancellation and disposal semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ffeff87e-f284-434d-87d3-843e21a7aebb

Copilot AI balanced review requested due to automatic review settings August 7, 2026 15:11

github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 7, 2026

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 15:11 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Comment thread src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs

Comment thread src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs

github-actions Bot mentioned this pull request Aug 7, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

Adam Ratzman (adamint) mentioned this pull request Aug 7, 2026

Tracking: open VS Code extension issues with no active PR #19066

Open

8 tasks

Copilot AI review requested due to automatic review settings August 7, 2026 17:29

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 17:30 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Comment thread src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs

Copilot AI review requested due to automatic review settings August 7, 2026 19:18

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 19:19 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Comment thread src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs

Copilot AI review requested due to automatic review settings August 7, 2026 19:58

Adam Ratzman (adamint) force-pushed the adamint/feature-15575-testing-dashboard branch from f2acafc to 10b6337 Compare August 7, 2026 19:58

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 19:59 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings August 7, 2026 20:25

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 20:27 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings August 7, 2026 21:26

Copilot started reviewing on behalf of Adam Ratzman (adamint) August 7, 2026 21:27 View session

Copilot AI reviewed Aug 7, 2026

View reviewed changes

Merge remote-tracking branch 'microsoft/main' into adamint/feature-15…

9880d13

…575-testing-dashboard

Uh oh!

Conversation

Adam Ratzman (adamint) commented Aug 7, 2026

Description

What runs when the dashboard is enabled

Lifecycle fixes found along the way

Notes for reviewers

Follow-ups deliberately not in this change

Checklist

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Alex Crome (afscrome) commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Review details

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants