Skip to content

dracut: Drop disable-xattr dracut patch, introduce config to optionally enable it#10070

Merged
Camelron merged 4 commits into3.0-devfrom
cameronbaird/dracut-xattr
Aug 24, 2024
Merged

dracut: Drop disable-xattr dracut patch, introduce config to optionally enable it#10070
Camelron merged 4 commits into3.0-devfrom
cameronbaird/dracut-xattr

Conversation

@Camelron
Copy link
Copy Markdown
Contributor

@Camelron Camelron commented Aug 8, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Removes a hack to permanently disable copying of extended attributes for files in our initramfs. Instead introduce this behavior as an option by packaging DRACUT_NO_XATTR as a configuration in dracut-noxattr.rpm

Change Log
  • Drop 0002-disable-xattr.patch
  • Introduce dracut-noxattr subpackage to expose this behavior as an option
Does this affect the toolchain?

NO

Associated issues
Test Methodology

@Camelron Camelron requested a review from a team as a code owner August 8, 2024 21:46
@Camelron Camelron changed the title Drop disable-xattr dracut patch, introduce config to optionally enable it dracut: Drop disable-xattr dracut patch, introduce config to optionally enable it Aug 8, 2024
@Camelron
Copy link
Copy Markdown
Contributor Author

Camelron commented Aug 9, 2024

Depends on a separate change to build cp with xattr support: b6e4260

@christopherco
Copy link
Copy Markdown
Collaborator

Depends on a separate change to build cp with xattr support: b6e4260

#10101

Comment thread SPECS/dracut/50-noxattr.conf Outdated
@Camelron Camelron force-pushed the cameronbaird/dracut-xattr branch from e05949b to ff6e47c Compare August 19, 2024 16:29
Signed-off-by: Chris Co <chrco@microsoft.com>
@Camelron Camelron merged commit 3c01c0a into 3.0-dev Aug 24, 2024
@Camelron Camelron deleted the cameronbaird/dracut-xattr branch August 24, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants