Enable xattr and acl support in coreutils.#10101
Merged
Conversation
christopherco
approved these changes
Aug 10, 2024
12 tasks
Currently, coreutils does not have xattr and acl support enabled. This means that commands like `cp --preserve=xattr` will fail. This is annoying when trying to preserve filecaps and SELinux labels. This change fixes this. FYI: This change adds ~250KiB to the image size.
edcbb6a to
0891d1d
Compare
PawelWMS
reviewed
Aug 12, 2024
PawelWMS
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, coreutils does not have xattr and acl support enabled. This means that commands like
cp --preserve=xattrwill fail. This is annoying when trying to preserve filecaps and SELinux labels. This change fixes this.FYI: This change adds ~250KiB to the image size.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassChange Log
Does this affect the toolchain?
YES
Test Methodology