Skip to content

Enable xattr and acl support in coreutils.#10101

Merged
cwize1 merged 2 commits into3.0-devfrom
user/chrisgun/cpXattr
Aug 13, 2024
Merged

Enable xattr and acl support in coreutils.#10101
cwize1 merged 2 commits into3.0-devfrom
user/chrisgun/cpXattr

Conversation

@cwize1
Copy link
Copy Markdown
Contributor

@cwize1 cwize1 commented Aug 10, 2024

Currently, coreutils does not have xattr and acl support enabled. This means that commands like cp --preserve=xattr will fail. This is annoying when trying to preserve filecaps and SELinux labels. This change fixes this.

FYI: This change adds ~250KiB to the image size.


Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Change Log
  • coreutils: Enabled xattr and acl support
Does this affect the toolchain?

YES

Test Methodology
  • Manually built and tested new coreutils
  • Ran buddy build to ensure toolchain builds.

@cwize1 cwize1 requested review from a team as code owners August 10, 2024 00:34
Currently, coreutils does not have xattr and acl support enabled. This
means that commands like `cp --preserve=xattr` will fail. This is
annoying when trying to preserve filecaps and SELinux labels. This
change fixes this.

FYI: This change adds ~250KiB to the image size.
@cwize1 cwize1 force-pushed the user/chrisgun/cpXattr branch from edcbb6a to 0891d1d Compare August 12, 2024 19:29
Comment thread toolkit/resources/manifests/package/toolchain_aarch64.txt
Comment thread toolkit/resources/manifests/package/toolchain_aarch64.txt
@cwize1 cwize1 merged commit 911793f into 3.0-dev Aug 13, 2024
@cwize1 cwize1 deleted the user/chrisgun/cpXattr branch August 13, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants