Merged
Conversation
anphel31
reviewed
Oct 1, 2024
anphel31
approved these changes
Oct 2, 2024
Camelron
approved these changes
Oct 2, 2024
sameluch
approved these changes
Oct 2, 2024
hbeberman
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Default presets were introduced here #8028. The default firewall was firewalld which is not fully supported for Azl3. Therefore, set as iptables.
azurelinux-release-3.0-20, the iptables service will be recognized as being allowed by the preset but will NOT be enabled by default. That being said, if an iptables.rpm upgrade comes in afterwards, the rules WILL be turned onazurelinux-release-3.0-20), the preset will show that the iptables service is disabled by the preset but iptables WILL continue to run even after rebootEx of a downgrade then reboot:
Change Log
Does this affect the toolchain?
YES
Associated issues
Test Methodology
sudo make image REBUILD_TOOLS=y CONFIG_FILE=./imageconfigs/core-efi.json QUICK_REBUILD_PACKAGES=y DAILY_BUILD_ID=3-0-20240925 ALLOW_TOOLCHAIN_REBUILDS=yhttps://dev.azure.com/mariner-org/mariner/_build/results?buildId=650648&view=results