Skip to content

Enable iptables by default#10597

Merged
rlmenge merged 2 commits into3.0-devfrom
rlmenge/3.0/iptables-enable
Oct 2, 2024
Merged

Enable iptables by default#10597
rlmenge merged 2 commits into3.0-devfrom
rlmenge/3.0/iptables-enable

Conversation

@rlmenge
Copy link
Copy Markdown
Contributor

@rlmenge rlmenge commented Oct 1, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Default presets were introduced here #8028. The default firewall was firewalld which is not fully supported for Azl3. Therefore, set as iptables.

  • For an image upgrade, this PR will cause the iptables.service to run by default and thus, will introduce firewall rules by default.
  • For a package upgrade to azurelinux-release-3.0-20, the iptables service will be recognized as being allowed by the preset but will NOT be enabled by default. That being said, if an iptables.rpm upgrade comes in afterwards, the rules WILL be turned on
  • For a package downgrade to an older package (< azurelinux-release-3.0-20), the preset will show that the iptables service is disabled by the preset but iptables WILL continue to run even after reboot
    Ex of a downgrade then reboot:
image
Change Log
  • Enable iptables service by default
Does this affect the toolchain?

YES

Associated issues
Test Methodology
  • locally built vhdx and booted in hyperv and saw iptables
    sudo make image REBUILD_TOOLS=y CONFIG_FILE=./imageconfigs/core-efi.json QUICK_REBUILD_PACKAGES=y DAILY_BUILD_ID=3-0-20240925 ALLOW_TOOLCHAIN_REBUILDS=y
image image

@rlmenge rlmenge requested a review from a team as a code owner October 1, 2024 22:30
Comment thread SPECS/azurelinux-release/azurelinux-release.spec Outdated
@rlmenge rlmenge merged commit fd3f001 into 3.0-dev Oct 2, 2024
@rlmenge rlmenge deleted the rlmenge/3.0/iptables-enable branch October 2, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants