Skip to content

Updates to azurelinux-release#8028

Merged
ddstreetmicrosoft merged 11 commits into3.0-devfrom
ddstreet/azure-release
Feb 29, 2024
Merged

Updates to azurelinux-release#8028
ddstreetmicrosoft merged 11 commits into3.0-devfrom
ddstreet/azure-release

Conversation

@ddstreetmicrosoft
Copy link
Copy Markdown
Contributor

Several updates to the azurelinux-release package:

  • remove %%config(noreplace) from *-release files
  • define dist_version and use local macros
  • move *-release and issue files under %%_libdir and make %%_sysconfdir symlinks
  • use consistent creation of here documents
  • add issue.d dir
  • move macros.dist into this package
  • Add default systemd presets

@ddstreetmicrosoft ddstreetmicrosoft requested review from a team as code owners February 22, 2024 14:11
@ddstreetmicrosoft ddstreetmicrosoft mentioned this pull request Feb 22, 2024
12 tasks
@ddstreetmicrosoft ddstreetmicrosoft requested a review from a team as a code owner February 22, 2024 14:16
Comment thread SPECS/azurelinux-release/90-default.preset
Comment thread SPECS/mariner-rpm-macros/mariner-rpm-macros.signatures.json
Comment thread SPECS/systemd/systemd.spec
@ddstreetmicrosoft ddstreetmicrosoft force-pushed the ddstreet/azure-release branch 4 times, most recently from 06d2631 to 4c5bbdc Compare February 26, 2024 20:59
Comment thread SPECS/azurelinux-release/azurelinux-release.spec Outdated
@ddstreetmicrosoft ddstreetmicrosoft force-pushed the ddstreet/azure-release branch 2 times, most recently from 130f06c to ad8792b Compare February 26, 2024 22:34
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes. The only reason I haven't approved yet, is that we probably need to wait for #8013 to define the azl macro systemd.spec depends. For now, unfortunately, we can't deliver it from azurelinux-release for that spec. Once that's in and systemd builds, I think we'll be good to go.

@ddstreetmicrosoft ddstreetmicrosoft force-pushed the ddstreet/azure-release branch 8 times, most recently from 860efe1 to 0524cc3 Compare February 29, 2024 01:21
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The full build you linked a while earlier failed due to missing signatures, though. The signatures are definitely here in this version of the PR, so I hope that's not going to fail anymore. I just started another build. Before you merge, please make sure there are no regressions in the toolchain and package builds.

@ddstreetmicrosoft
Copy link
Copy Markdown
Contributor Author

Changes look good. The full build you linked a while earlier failed due to missing signatures, though. The signatures are definitely here in this version of the PR, so I hope that's not going to fail anymore. I just started another build. Before you merge, please make sure there are no regressions in the toolchain and package builds.

unfortunately that failed due to a mismatch in the nftables signatures, but it did get through the toolchain build.

I rebased and added a commit to fix the nftables signatures also.

@ddstreetmicrosoft
Copy link
Copy Markdown
Contributor Author

@ddstreetmicrosoft ddstreetmicrosoft merged commit fad9ba6 into 3.0-dev Feb 29, 2024
@ddstreetmicrosoft ddstreetmicrosoft deleted the ddstreet/azure-release branch February 29, 2024 16:53
@rlmenge rlmenge mentioned this pull request Oct 1, 2024
12 tasks
rlmenge added a commit that referenced this pull request Oct 2, 2024
Default presets were introduced in PR #8028. The default firewall was firewalld which is not fully supported for Azl3. Therefore, set as iptables.

- For an image upgrade, this PR will cause the iptables.service to run by default and thus, will introduce firewall rules by default.
- For a package upgrade to azurelinux-release-3.0-20, the iptables service will be recognized as being allowed by the preset but will NOT be enabled by default. That being said, if an iptables.rpm upgrade comes in afterwards, the rules WILL be turned on
- For a package downgrade to an older package (< azurelinux-release-3.0-20), the preset will show that the iptables service is disabled by the preset but iptables WILL continue to run even after reboot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants