Bphilip/refactor version entangle check add release number#12817
Closed
Bphilip/refactor version entangle check add release number#12817
Conversation
microsoft-github-policy-service
Bot
added
Packaging
Tools
3.0-dev
binujp
force-pushed
the
bphilip/refactor-version-entangle-check-add-minor-1
branch
from
770903c to
892aab0
Compare
binujp
force-pushed
the
bphilip/refactor-version-entangle-check-add-minor-1
branch
from
892aab0 to
26bff49
Compare
12 tasks
PawelWMS
reviewed
Mar 6, 2025
Comment on lines
+158
to
+159
| if verbose: | ||
| print(f"Processing group: {group}") |
Contributor
There was a problem hiding this comment.
Suggestion: instead of repeating if verbose: what do you think about creating a wrapper print_verbose function?
PawelWMS
previously approved these changes
Mar 6, 2025
Contributor
PawelWMS
left a comment
PawelWMS
left a comment
There was a problem hiding this comment.
One small suggestion but looks good to me.
binujp
commented
Mar 7, 2025
| (['sdkver'], sdkver_matching_groups, {}), | ||
| (['epoch', 'version', 'release'], version_release_matching_groups, {}), | ||
| (['epoch', 'version'], version_matching_groups, {}), | ||
| (['last-known-kernel'], oot_kmodule_matching_groups, |
Contributor
Author
There was a problem hiding this comment.
Now that I look at this again, can't I just pass only { tag: value } instead of a tag array and a tag: value dict? Hmm..
…12819) Co-authored-by: corvus-callidus <108946721+corvus-callidus@users.noreply.github.com>
This reverts commit 7cdbd37.
Adding slang-devel to kernel spec, enabling perf tui Perf's Makefile has a slang-devel check, which enables tui when slang is detected. (https://github.com/microsoft/CBL-Mariner-Linux-Kernel/blob/rolling-lts/mariner-3/6.6.78.1/tools/perf/Makefile.config#L765). Adding this package at built time will allow perf --tui support Co-authored-by: Andy Zaugg <azaugg@linkedin.com>
This reverts commit 389af4a.
…High] & CVE-2024-28180 CVE-2025-27144 [Medium] - branch 3.0-dev (#12875) Co-authored-by: Kanishk Bansal <103916909+Kanishk-Bansal@users.noreply.github.com>
… to 24.1.6 to fix CVE-2025-26594, CVE-2025-26595, CVE-2025-26596, CVE-2025-26597, CVE-2025-26598, CVE-2025-26599, CVE-2025-26600, CVE-2025-26601[High] - branch 3.0-dev (#12876)
…E-2025-27423 [High] - branch 3.0-dev (#12877)
Signed-off-by: Chris Co <chrco@microsoft.com>
License file got desynced due to 0de902e This change restores the LICENSES-MAP.md file. Signed-off-by: Chris Co <chrco@microsoft.com>
Starting in kernel v6.6.76, our automated testing encountered failures
on specific bare-metal systems where, after a kernel panic, sometimes
the kernel's panic message was not seen in the system's IPMI SEL.
After bisecting the changes between v6.6.75 to v6.6.76, we isolated the
offending commit to:
serial: 8250: Adjust the timeout for FIFO mode
To restore functionality, revert the offending commit. We will continue
investigating the issue separately.
Apply to both kernel and kernel-64k.
Signed-off-by: Chris Co <chrco@microsoft.com>
Include new subpackages to access the official azure linux cloud-native package repository and preview package repository on packages.microsoft.com. Signed-off-by: Chris Co <chrco@microsoft.com>
microsoft-github-policy-service
Bot
added
the
specs-extended
Contributor
Author
|
Superseded by #12910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
MOFED and associated kernel modules did not include kernel minor version in the entangle check. check_entangle script did not provide enough details when it failed. Zeroing in on the exact mis-match needed additional effort. Added a unit test to make sure the script was indeed doing everything as expected.
There was some refactoring done to the script to make the workflow more compact.
Change Log
Does this affect the toolchain?
YES/NO
NO
Associated issues
Links to CVEs
Test Methodology