Bphilip/refactor version entangle check add release number#12910
Merged
christopherco merged 5 commits into3.0-devfrom Mar 19, 2025
Merged
Bphilip/refactor version entangle check add release number#12910christopherco merged 5 commits into3.0-devfrom
christopherco merged 5 commits into3.0-devfrom
Conversation
12 tasks
microsoft-github-policy-service
Bot
added
Packaging
Tools
3.0-dev
PawelWMS
previously approved these changes
Mar 12, 2025
rlmenge
previously approved these changes
Mar 12, 2025
Collaborator
|
@binujp kindly requesting to fix up the PR description to remove unnecessary confusion |
Contributor
Author
This had not gone through shiproom. I thought I was maintaining momentum from when mofed oot packages were integrated into core. I will go through due process. |
binujp
dismissed stale reviews from rlmenge and PawelWMS
The base branch was changed.
microsoft-github-policy-service
Bot
added
the
specs-extended
added 3 commits
March 18, 2025 17:46
…ttps://github.com/microsoft/azurelinux into bphilip/refactor-version-entangle-check-add-minor-2
christopherco
approved these changes
Mar 19, 2025
christopherco
deleted the
bphilip/refactor-version-entangle-check-add-minor-2
branch
SumitJenaHCL
pushed a commit
to SumitJenaHCL/azurelinux
that referenced
this pull request
Aug 20, 2025
…#12910) MOFED and associated kernel modules did not include kernel minor version in the entangle check. check_entangle script did not provide enough details when it failed. Added a unit test to make sure the script was indeed doing everything as expected. There was some refactoring done to the script to make the workflow more compact. Co-authored-by: Binu Jose Philip <bphilip@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
MOFED and associated kernel modules did not include kernel minor version in the entangle check. check_entangle script did not provide enough details when it failed.
Added a unit test to make sure the script was indeed doing everything as expected. There was some refactoring done to the script to make the workflow more compact.
Change Log
Does this affect the toolchain?
YES/NO
NO
Test Methodology