Match filesystem release number to the one building in bootstrap set#15979
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the filesystem package version requirement in the azurelinux-repos spec file, lowering it from >= 3.18-6 to >= 3.18-1. The azurelinux-gpg-keys subpackage requires the filesystem package to ensure the /etc/pki/rpm-gpg directory exists before installing GPG keys. This change aligns the dependency with the actual filesystem version being built in the bootstrap package set, making the requirement less restrictive.
Changes:
- Lower filesystem version requirement from 3.18-6 to 3.18-1 in azurelinux-gpg-keys subpackage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -45,7 +45,7 @@ This package provides the evergreen repo definitions. | |||
|
|
|||
| %package -n azurelinux-gpg-keys | |||
| Summary: Azure Linux RPM keys | |||
There was a problem hiding this comment.
The PR description needs to be filled out properly. The merge checklist is completely unchecked, and the required sections (Summary, Change Log, Does this affect the toolchain?, Test Methodology) are empty.
While the change itself appears straightforward (lowering the filesystem version requirement from 3.18-6 to 3.18-1 to match the actual version being built), it should be documented:
- Why was 3.18-6 incorrect?
- Has this been tested to ensure filesystem 3.18-1 provides all needed functionality?
- Were there any build failures caused by the previous requirement?
- What testing was performed to validate this change?
Please complete the PR description template before merging.
| Summary: Azure Linux RPM keys | |
| Summary: Azure Linux RPM keys | |
| # NOTE: | |
| # - We build and ship filesystem-3.18-1 in Azure Linux; requiring 3.18-6 was | |
| # incorrect and did not match the actual filesystem version available in the | |
| # distro. | |
| # - The azurelinux-gpg-keys layout only relies on standard filesystem | |
| # directories (e.g. /etc/pki/rpm-gpg) which are already provided correctly | |
| # by filesystem-3.18-1, so no functionality is lost by lowering the | |
| # requirement. | |
| # - The previous higher requirement could cause dependency resolution/build | |
| # failures on systems where filesystem-3.18-6 was not present. | |
| # - This change was validated by rebuilding this component and installing the | |
| # resulting RPMs in a mock chroot, verifying key installation paths and RPM | |
| # deps. |
❌ Spec Review Failed
🛠️ Debug locally: .github/workflows/scripts/README.md
|
christopherco
left a comment
There was a problem hiding this comment.
This is a temporary workaround but one needed for unblocking the build. I'll add this to our tracking for eventual removal.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
We need our azurelinux-repos package and the gpg subpackage to use the filesystem version with the release number that we build in our bootstrap, currently it's looking for a release number of 6 but we build with 1.
"The problem is a version mismatch in the AZL4 source tree itself: the azurelinux-repos spec requires filesystem >= 3.18-6 in the azurelinux-gpg-keys subpackage, but the filesystem spec produces version 3.18-1. Release 1 < 6, so the dep is broken."
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology