Skip to content

Match filesystem release number to the one building in bootstrap set #15979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Feb 25, 2026
+1 −1
Merged

Match filesystem release number to the one building in bootstrap set #15979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/comps/azurelinux-repos/azurelinux-repos.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Summary: Azure Linux package repositories
Name: azurelinux-repos
Version: 4.0
Release: 1%{?dist}

Check notice on line 7 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Consider using %autorelease for the Release tag to follow the recommended versioning practice. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/)
License: MIT
URL: https://aka.ms/azurelinux

Expand Down Expand Up @@ -45,7 +45,7 @@

%package -n azurelinux-gpg-keys
Summary: Azure Linux RPM keys
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description needs to be filled out properly. The merge checklist is completely unchecked, and the required sections (Summary, Change Log, Does this affect the toolchain?, Test Methodology) are empty.

While the change itself appears straightforward (lowering the filesystem version requirement from 3.18-6 to 3.18-1 to match the actual version being built), it should be documented:

  • Why was 3.18-6 incorrect?
  • Has this been tested to ensure filesystem 3.18-1 provides all needed functionality?
  • Were there any build failures caused by the previous requirement?
  • What testing was performed to validate this change?

Please complete the PR description template before merging.

Suggested change
Summary: Azure Linux RPM keys
Summary: Azure Linux RPM keys
# NOTE:
# - We build and ship filesystem-3.18-1 in Azure Linux; requiring 3.18-6 was
# incorrect and did not match the actual filesystem version available in the
# distro.
# - The azurelinux-gpg-keys layout only relies on standard filesystem
# directories (e.g. /etc/pki/rpm-gpg) which are already provided correctly
# by filesystem-3.18-1, so no functionality is lost by lowering the
# requirement.
# - The previous higher requirement could cause dependency resolution/build
# failures on systems where filesystem-3.18-6 was not present.
# - This change was validated by rebuilding this component and installing the
# resulting RPMs in a mock chroot, verifying key installation paths and RPM
# deps.

Copilot uses AI. Check for mistakes.
Requires: filesystem >= 3.18-6
Requires: filesystem >= 3.18-1

Check warning on line 48 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

The versioned dependency 'Requires%3A filesystem >= 3.18-1' should only be used if that minimum version is truly required; otherwise use an unversioned dependency. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies)

%description -n azurelinux-gpg-keys
This package provides the RPM signature keys.
Expand All @@ -57,8 +57,8 @@

%install
# Install the keys
install -d -m 755 $RPM_BUILD_ROOT/etc/pki/rpm-gpg

Check notice on line 60 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Consider using %{_sysconfdir} (and other path macros) instead of hard-coded /etc paths in %install for consistency with macro guidance. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/)
install -m 644 %{_sourcedir}/RPM-GPG-KEY* $RPM_BUILD_ROOT/etc/pki/rpm-gpg/

Check failure on line 61 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Source files are referenced via %{_sourcedir} (e.g.%2C archmap and RPM-GPG-KEY*). Source# files must be referenced using their %{SOURCE#} macros rather than %{_sourcedir}. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/RPM_Source_Dir/)

# Link the primary/secondary keys to arch files, according to archmap.
# Ex: if there's a key named RPM-GPG-KEY-azurelinux-4.0-primary, and archmap
Expand Down Expand Up @@ -228,7 +228,7 @@
done
rm -f "$TMPRING"

%files

Check failure on line 231 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

No license text is included in any %files list. If the license text is present in sources (or required by the MIT license)%2C it must be included with %license; if missing%2C a copy must be added. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/)
%dir /etc/yum.repos.d
%config(noreplace) /etc/yum.repos.d/azurelinux.repo

Expand All @@ -236,7 +236,7 @@
%config(noreplace) /etc/yum.repos.d/azurelinux-evergreen.repo


%files -n azurelinux-gpg-keys

Check failure on line 239 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

The independent azurelinux-gpg-keys subpackage does not include applicable license text in its %files section. Independent subpackages must include license texts relevant to their contents. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing)
%dir /etc/pki/rpm-gpg
/etc/pki/rpm-gpg/RPM-GPG-KEY-*

Expand All @@ -246,7 +246,7 @@
# /usr/share/ima/ca.der


%changelog

Check failure on line 249 in base/comps/azurelinux-repos/azurelinux-repos.spec

View workflow job for this annotation

GitHub Actions / review / Spec Review 

Manual %changelog is missing an entry for the current Version/Release (4.0-1%{?dist}); changelog entries must be added whenever the E-V-R changes. (Ref: https%3A//docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/)
* Mon Aug 11 2025 Samyak Jain <samyak.jn11@gmail.com> - 44-0.1
- Rawhide is now F44

Expand Down
Loading