workaround(coin-or-Cbc): Disable HiGHS support#16626
workaround(coin-or-Cbc): Disable HiGHS support#16626christopherco merged 1 commit intotomls/base/mainfrom
Conversation
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
There was a problem hiding this comment.
Pull request overview
Adds an Azure Linux-specific workaround for coin-or-Cbc to build without the optional HiGHS backend (since coin-or-HiGHS isn’t available), while keeping the primary solver (Clp) unaffected.
Changes:
- Moved
coin-or-Cbcto a dedicated*.comp.tomlfile to apply overlays. - Added overlays to disable the HiGHS
BuildRequiresand remove HiGHS-related%buildconfigure flags. - Removed the now-duplicated
coin-or-Cbcentry frombase/comps/components.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| base/comps/components.toml | Removes the inline coin-or-Cbc table so the dedicated component file is the single source of truth. |
| base/comps/coin-or-Cbc/coin-or-Cbc.comp.toml | Introduces overlays intended to disable HiGHS support in the upstream spec. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christopherco
force-pushed
the
chrco/fix-coin-or-Cbc
branch
from
4ec66ac to
b262a08
Compare
christopherco
force-pushed
the
chrco/fix-coin-or-Cbc
branch
from
b262a08 to
718f0a3
Compare
|
Note: I went this direction instead of replacing the |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coin-or-HiGHS is not available in Azure Linux. HiGHS is an optional LP solver backend; Cbc's primary solver (Clp) is unaffected. Comment out the BuildRequires and configure flags for HiGHS. Re-enable if coin-or-HiGHS is added to the distro.
christopherco
force-pushed
the
chrco/fix-coin-or-Cbc
branch
from
718f0a3 to
4f7a4a8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [[components.coin-or-Cbc.overlays]] | ||
| description = "Remove HiGHS --with-highs-incdir configure flag" | ||
| type = "spec-search-replace" | ||
| section = "%build" | ||
| regex = ' --with-highs-incdir=%\{_includedir\}/highs \\' |
There was a problem hiding this comment.
The two spec-search-replace overlays replace the HiGHS configure-option lines with a standalone line-continuation (\). That leaves “empty” continuation lines in the %configure invocation, which is harder to reason about and can be brittle if the surrounding %configure formatting changes.
Since the upstream spec already isolates all HiGHS logic under %ifnarch %{ix86} (only two occurrences, both for HiGHS), consider making the workaround more robust by disabling that conditional block entirely (e.g., replace %ifnarch %{ix86} with an always-false %if 0) or by replacing the whole option line with an empty string (so the option line disappears rather than becoming a bare continuation).
There was a problem hiding this comment.
Already considered. See my comment here #16626 (comment)
coin-or-HiGHS is not available in Azure Linux. HiGHS is an optional LP solver backend; Cbc's primary solver (Clp) is unaffected. Comment out the BuildRequires and configure flags for HiGHS. Re-enable if coin-or-HiGHS is added to the distro.