Skip to content

workaround(coin-or-Cbc): Disable HiGHS support #16626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 13, 2026
Merged

workaround(coin-or-Cbc): Disable HiGHS support #16626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions base/comps/coin-or-Cbc/coin-or-Cbc.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
[components.coin-or-Cbc]

# coin-or-HiGHS is not available in Azure Linux. Disable HiGHS support by
# removing the HiGHS BuildRequires entry and stripping the configure flags.
# HiGHS is an optional LP solver backend; Cbc's primary solver (Clp) is unaffected.

[[components.coin-or-Cbc.overlays]]
description = "Disable HiGHS BuildRequires — coin-or-HiGHS not available in Azure Linux"
type = "spec-remove-tag"
tag = "BuildRequires"
value = "pkgconfig(highs)"

[[components.coin-or-Cbc.overlays]]
description = "Remove HiGHS --with-highs-incdir configure flag"
type = "spec-search-replace"
section = "%build"
regex = ' --with-highs-incdir=%\{_includedir\}/highs \\'
Comment on lines +13 to +17
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two spec-search-replace overlays replace the HiGHS configure-option lines with a standalone line-continuation (\). That leaves “empty” continuation lines in the %configure invocation, which is harder to reason about and can be brittle if the surrounding %configure formatting changes.

Since the upstream spec already isolates all HiGHS logic under %ifnarch %{ix86} (only two occurrences, both for HiGHS), consider making the workaround more robust by disabling that conditional block entirely (e.g., replace %ifnarch %{ix86} with an always-false %if 0) or by replacing the whole option line with an empty string (so the option line disappears rather than becoming a bare continuation).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@christopherco christopherco Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already considered. See my comment here #16626 (comment)

replacement = " \\"

[[components.coin-or-Cbc.overlays]]
description = "Remove HiGHS --with-highs-lib configure flag"
type = "spec-search-replace"
section = "%build"
regex = ' --with-highs-lib=-lhighs \\'
replacement = " \\"
1 change: 0 additions & 1 deletion base/comps/components.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"]
[components.cockpit]
[components.codec2]
[components.cogl]
[components.coin-or-Cbc]
[components.coin-or-Cgl]
[components.coin-or-Clp]
[components.coin-or-CoinUtils]
Expand Down
Loading