fix(avahi): keep normal dist tag - #18317
Merged
Merged
Conversation
Override __bootstrap while retaining the bootstrap bcond so reduced-feature builds use the standard Azure Linux dist tag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures Avahi keeps its reduced bootstrap feature set without adding ~bootstrap to the Azure Linux dist tag.
Changes:
- Overrides
%__bootstrapwith an empty macro. - Refreshes generated spec release and component lock.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
base/comps/avahi/avahi.comp.toml |
Defines the bootstrap suffix override. |
specs/a/avahi/avahi.azl.macros |
Renders the empty macro override. |
specs/a/avahi/avahi.spec |
Bumps the package release. |
locks/avahi.lock |
Refreshes the input fingerprint. |
reubeno
marked this pull request as ready for review
August 4, 2026 22:17
tobiasb-ms
requested changes
Aug 4, 2026
tobiasb-ms
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forced enable the
bootstrapbcond onavahifor AZL4 -- because it allows us a low-maintenance way of minimizing dependencies for building and runningavahi. We're not using it for traditional bootstrapping purposes.However, because
bootstrapends up set to1, that triggers thedisttag for the package to include%{__bootstrap}, which is centrally defined in RPM macros to add~bootstrap. (Note that this is visible in PROD but masked in the DEV environment, which has a legacy koji configuration that forces thedisttag to.azl4. That configuration setting was not propagated to the PROD environment.)We intentionally override
__bootstrapwhile retaining thebootstrapbcondin order to maintain the reduced-feature builds but also get the standard Azure Linuxdisttag.Validation
azldevbuild