Skip to content

Added cross-binutils and kernel-cross-headers for AMD64.#6815

Merged
PawelWMS merged 40 commits intomicrosoft:mainfrom
PawelWMS:pawelwi/dadelan/cross
Dec 6, 2023
Merged

Added cross-binutils and kernel-cross-headers for AMD64.#6815
PawelWMS merged 40 commits intomicrosoft:mainfrom
PawelWMS:pawelwi/dadelan/cross

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Nov 20, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

First part of migrating #5569 to the latest main. We're adding packages to enable cross-compilation for the ARM64 architecture on ADM64 machines.

Change Log
  • Added cross-compilation packages for binutils and kernel-headers.
Does this affect the toolchain?

Yes.

Associated issues
Test Methodology

@PawelWMS PawelWMS requested a review from dallasd1 November 20, 2023 21:56
@PawelWMS PawelWMS requested review from a team as code owners November 20, 2023 21:56
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Nov 20, 2023
Comment thread SPECS/binutils/binutils.spec
Comment thread SPECS/kernel-headers/kernel-headers.spec
Patch4: CVE-2022-38533.patch
Patch5: CVE-2022-4285.patch
# The gold linker doesn't understand the 'module_info.ld' script passed to all linkers and the tests fail to correctly link.
Patch6: disable_gold_test.patch
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more than open for better solutions here, so we can still run these tests.

Comment thread SPECS/binutils/binutils.spec
Comment thread SPECS/binutils/binutils.spec
Comment thread toolkit/resources/manifests/package/toolchain_x86_64.txt Outdated
Comment thread SPECS/kernel-headers/kernel-headers.spec
Comment thread toolkit/resources/manifests/package/toolchain_x86_64.txt Outdated
Copy link
Copy Markdown
Contributor

@Camelron Camelron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left some minor comments/questions.

Comment thread SPECS/binutils/binutils.spec
@PawelWMS PawelWMS merged commit d74ec82 into microsoft:main Dec 6, 2023
@PawelWMS PawelWMS deleted the pawelwi/dadelan/cross branch December 6, 2023 18:39
gmileka pushed a commit that referenced this pull request Dec 7, 2023
Co-authored-by: dallasd1 <dadelan@microsoft.com>
PawelWMS pushed a commit to PawelWMS/CBL-Mariner that referenced this pull request Dec 8, 2023
henryli001 pushed a commit that referenced this pull request Jan 10, 2024
Co-authored-by: dallasd1 <dadelan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants