Added cross-compilation binutils and kernel-headers.#6945
Merged
PawelWMS merged 11 commits intomicrosoft:mainfrom Jan 18, 2024
Merged
Added cross-compilation binutils and kernel-headers.#6945PawelWMS merged 11 commits intomicrosoft:mainfrom
binutils and kernel-headers.#6945PawelWMS merged 11 commits intomicrosoft:mainfrom
Conversation
anphel31
approved these changes
Dec 8, 2023
jslobodzian
approved these changes
Dec 8, 2023
b5d0276 to
b9e341a
Compare
binutils and kernel-headers.
12 tasks
rlmenge
reviewed
Jan 17, 2024
rlmenge
approved these changes
Jan 18, 2024
Contributor
Author
|
Builds finished successfully, merging. |
PawelWMS
added a commit
to PawelWMS/CBL-Mariner
that referenced
this pull request
Jan 19, 2024
This was referenced Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This is a fix for a breaking change I introduced in #6815. The original change caused other package to start failing with the
configure: error: C compiler cannot create executableserror and the nativebinutilspackage containedcross-<binary_name>.mofiles meant forcross-binutils-commoninstead of the plain<binary_name>.mo. The original change was reverted and this is an updated version.The main changes are:
binutilsand have multipleconfigureandmakecalls point to that directory, I've added copies of the source for each pair ofconfigureandmakecalls. For reasons still unknown to me, the original approach caused theconfigure: error: C compiler cannot create executableserror. I'd greatly appreciate an explanation from someone more experienced, what was wrong and how to avoid copying the original sources. For now, however, that I've implemented the said workaround and created a separate bug to address it in the future.cross-<binary_name>.moonly for thecross-binutils-commonsubpackage.Change Log
binutils.binutils.spec.Does this affect the toolchain?
Yes.
Associated issues
cross-binutilsandkernel-cross-headersfor AMD64. #6815Test Methodology
binutilsalong with a build of alibdbas a test of introduced changes.