Skip to content

Added a cross-compilation subpackage for aarch64 into gcc.#6996

Merged
PawelWMS merged 58 commits intomainfrom
pawelwi/dadelan/cross_gcc_glibc
Jan 25, 2024
Merged

Added a cross-compilation subpackage for aarch64 into gcc.#6996
PawelWMS merged 58 commits intomainfrom
pawelwi/dadelan/cross_gcc_glibc

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Dec 13, 2023

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

WARNING: requires #6945 for full build or the fast-track PR check run.

Continuation of #6945 and the remainder of the changes from #5569. This change adds a cross-compilation version of gcc.

Change Log
  • Added cross-compilation build bits into gcc.spec.
  • Small spec clean-up.
Does this affect the toolchain?

Yes.

Associated issues
Test Methodology

@dmcilvaney
Copy link
Copy Markdown
Contributor

Haven't had a chance to look at the binutils pr, is there a set of pro/cons around for having a single .spec versus a dedicated cross version of the spec?

@PawelWMS PawelWMS requested a review from a team as a code owner January 17, 2024 19:24
@PawelWMS
Copy link
Copy Markdown
Contributor Author

Haven't had a chance to look at the binutils pr, is there a set of pro/cons around for having a single .spec versus a dedicated cross version of the spec?

Having it all in one file makes it definitely more robust, but splitting into separate spec files make it harder to track version upgrades and CVE fixes, as they will have to be duplicated among these separate specs.

My main worry with a single spec is that we're adding the package to the toolchain without a good reason, but I decided to postpone the solution until we enable custom per-spec macros - the idea you mentioned to me in December, which would allow us to build the same spec but with a slightly different configuration.

@PawelWMS PawelWMS force-pushed the pawelwi/dadelan/cross_gcc_glibc branch from ec98ac9 to 64c88c1 Compare January 19, 2024 19:45
Comment thread SPECS/gcc/gcc.spec Outdated
Comment thread SPECS/gcc/gcc.spec Outdated
Comment thread SPECS/gcc/gcc.spec
Comment thread SPECS/gcc/gcc.spec
Comment on lines 154 to 330
%configure \
--enable-shared \
--enable-threads=posix \
--disable-bootstrap \
--disable-multilib \
--enable-__cxa_atexit \
--enable-clocale=gnu \
--enable-default-pie \
--enable-languages=c,c++,fortran \
--disable-multilib \
--disable-bootstrap \
--enable-linker-build-id \
--enable-plugin \
--enable-default-pie \
--enable-shared \
--enable-threads=posix \
--with-system-zlib
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to the default configuration - just putting the arguments in alphabetical order whenever possible.:)

@PawelWMS PawelWMS merged commit 6e7be29 into main Jan 25, 2024
@PawelWMS PawelWMS deleted the pawelwi/dadelan/cross_gcc_glibc branch January 25, 2024 17:16
@PawelWMS PawelWMS mentioned this pull request Jan 25, 2024
12 tasks
PawelWMS added a commit that referenced this pull request Jan 25, 2024
Co-authored-by: dallasd1 <dadelan@microsoft.com>
PawelWMS added a commit that referenced this pull request Jan 29, 2024
#7465)

Co-authored-by: dallasd1 <dadelan@microsoft.com>
sindhu-karri added a commit that referenced this pull request Feb 6, 2024
Adub17030MS pushed a commit that referenced this pull request Feb 9, 2024
Xiaohong-Deng pushed a commit to Xiaohong-Deng/azurelinux that referenced this pull request Nov 23, 2024
… into gcc. (microsoft#7465)

Co-authored-by: dallasd1 <dadelan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants