Upgrade iscsi-initiator-utils from 2.1.4 to 2.1.9

[bfjelds (bfjelds)]

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

• The toolchain has been rebuilt successfully (or no changes were made to it)
• The toolchain/worker package manifests are up-to-date
• Any updated packages successfully build (or no packages were changed)
• Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
• Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
• All package sources are available
• cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
• LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
• All source files have up-to-date hashes in the *.signatures.json files
• sudo make go-tidy-all and sudo make go-test-coverage pass
• Documentation has been updated to match any changes to the build system
• Ready to merge

---

Summary

Upgrade to latest version

Change Log

• Update version to 2.1.9
• Get new patch files from https://src.fedoraproject.org/rpms/iscsi-initiator-utils/tree/f39
• Create mariner patch to fix build issues

Does this affect the toolchain?

YES/NO

Associated issues

Links to CVEs

Test Methodology

• https://dev.azure.com/mariner-org/mariner/_build/results?buildId=483007&view=results

[Muhammad Falak R Wani (mfrw)]

The previous version seems to be 6.x and we are moving to 2.x.
I am not an expert here, so can you please give a little context.

[bfjelds (bfjelds)]

the comments in the spreadsheet said to normalize the version. the version of open-iscsi that was previously used was 2.1.4 (not 6.), i think 6. versioning came from the fedora spec that was used as a basis. i tried to normalize to open-iscsi version (2.1.9).

[bfjelds (bfjelds)]

Pawel Winogrodzki (@PawelWMS) , can you provide clarity around what the versioning for this should be moving forward?

[jslobodzian]

I am supportive of this change. Since 2.0->3.0 is a breaking change, this gives us the chance to resolve.
If we wanted to be careful here, we could add the "Epoch" value to the version so that 1:2.1.9 supercedes 6.gack, but we don't offer upgrades from Mariner 2.0 to 3.0, so we're ok without the Epoch

[bfjelds (bfjelds)]

installed manually in local 3.0 VM:

root@ecp-machine [ /tmp/RPMS/x86_64 ]# tdnf install -y isns-utils-libs
Loaded plugin: tdnfrepogpgcheck

Installing:
isns-utils-libs           x86_64              0.101-2.azl3              mariner-official-base 508.09k           124.41k

Total installed size: 508.09k
Total download size: 124.41k
isns-utils-libs                         127391 100%
Testing transaction
Running transaction
Installing/Updating: isns-utils-libs-0.101-2.azl3.x86_64
root@ecp-machine [ /tmp/RPMS/x86_64 ]# ls -l
total 2748
-rw-r--r--. 1 root root  451352 Jan 16 17:34 iscsi-initiator-utils-2.1.9-1.azl3.x86_64.rpm
-rw-r--r--. 1 root root 2035091 Jan 16 17:34 iscsi-initiator-utils-debuginfo-2.1.9-1.azl3.x86_64.rpm
-rw-r--r--. 1 root root  177589 Jan 16 17:34 iscsi-initiator-utils-devel-2.1.9-1.azl3.x86_64.rpm
-rw-r--r--. 1 root root  108353 Jan 16 17:34 iscsi-initiator-utils-iscsiuio-2.1.9-1.azl3.x86_64.rpm
-rw-r--r--. 1 root root   29548 Jan 16 17:34 python3-iscsi-initiator-utils-2.1.9-1.azl3.x86_64.rpm
root@ecp-machine [ /tmp/RPMS/x86_64 ]# rpm -i $(ls)
Created symlink /etc/systemd/system/multi-user.target.wants/iscsiuio.service → /usr/lib/systemd/system/iscsiuio.service.
Created symlink /etc/systemd/system/sockets.target.wants/iscsiuio.socket → /usr/lib/systemd/system/iscsiuio.socket.
Created symlink /etc/systemd/system/sysinit.target.wants/iscsi-starter.service → /usr/lib/systemd/system/iscsi-starter.service.
Created symlink /etc/systemd/system/multi-user.target.wants/iscsid.service → /usr/lib/systemd/system/iscsid.service.
Created symlink /etc/systemd/system/sockets.target.wants/iscsid.socket → /usr/lib/systemd/system/iscsid.socket.
Created symlink /etc/systemd/system/sysinit.target.wants/iscsi-onboot.service → /usr/lib/systemd/system/iscsi-onboot.service.
Created symlink /etc/systemd/system/systemd-remount-fs.service.wants/iscsi-init.service → /usr/lib/systemd/system/iscsi-init.service.