Add package nss-mdns#7407
Merged
mfrw merged 2 commits intomicrosoft:mainfrom Feb 6, 2024
Merged
Conversation
mfrw
reviewed
Jan 23, 2024
mfrw
reviewed
Jan 23, 2024
Author
|
I have no access to rerun that CI check Check Package CGManifests / Check Package CGManifests but it seems like some internal Github issue, could i please ask someone to trigger it again? |
Member
|
Closing & Re-Opening PR to trigger stuck github checks |
mfrw
reviewed
Jan 31, 2024
| %{?ldconfig} | ||
|
|
||
| %posttrans | ||
| authselect enable-feature with-mdns4 &> /dev/null || : |
Member
There was a problem hiding this comment.
I have triggered a test build:
PR-7407
A note about the the prior test builds, they do build the package, but fail on authselect as it is a rutime dependency.
Have we verified the working of this package post a build ?
Author
mfrw
approved these changes
Feb 5, 2024
Member
mfrw
left a comment
There was a problem hiding this comment.
LGTM :)
Thanks @adobrzhansky
/cc @eric-desrochers for awareness.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Adds package nss-mdns to SPECS-EXTENDED
Does this affect the toolchain?
NO
Associated issues
Test Methodology
Reffering to a docs section i might need some help with that part