Skip to content

Add package nss-mdns#7407

Merged
mfrw merged 2 commits intomicrosoft:mainfrom
adobrzhansky:enable-nss-mdns
Feb 6, 2024
Merged

Add package nss-mdns#7407
mfrw merged 2 commits intomicrosoft:mainfrom
adobrzhansky:enable-nss-mdns

Conversation

@adobrzhansky
Copy link
Copy Markdown

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Adds package nss-mdns to SPECS-EXTENDED

Does this affect the toolchain?

NO

Associated issues
Test Methodology
  • local build

Reffering to a docs section i might need some help with that part

While it is possible to build packages with all sources inside the repo, our policy is generally to have the source compressed and placed on the source server. Uploading to the source server can only be accomplished by a CBL-Mariner developer. Please request help in your PR for uploading your sources to the source server. To check the source server see [https://cblmarinerstorage.blob.core.windows.net/sources/core/< source tar >].

@adobrzhansky adobrzhansky requested a review from a team as a code owner January 23, 2024 13:30
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Jan 23, 2024
Comment thread SPECS-EXTENDED/nss-mdns/nss-mdns.spec
Comment thread SPECS-EXTENDED/nss-mdns/nss-mdns.spec
@adobrzhansky
Copy link
Copy Markdown
Author

I have no access to rerun that CI check Check Package CGManifests / Check Package CGManifests but it seems like some internal Github issue, could i please ask someone to trigger it again?

@adobrzhansky adobrzhansky requested a review from mfrw January 24, 2024 21:01
@mfrw
Copy link
Copy Markdown
Member

mfrw commented Jan 30, 2024

Closing & Re-Opening PR to trigger stuck github checks

@mfrw mfrw closed this Jan 30, 2024
@mfrw mfrw reopened this Jan 30, 2024
%{?ldconfig}

%posttrans
authselect enable-feature with-mdns4 &> /dev/null || :
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have triggered a test build:
PR-7407

A note about the the prior test builds, they do build the package, but fail on authselect as it is a rutime dependency.

Have we verified the working of this package post a build ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package was installed with no issues the only thing was to add extended repo from where authselect would come.
install
All the modules after installation exists in the lib dir reference
libs
Plugin activation and proof of working reference
resolving

Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thanks @adobrzhansky
/cc @eric-desrochers for awareness.

@mfrw mfrw added the specs-extended PR to fix SPECS-EXTENDED label Feb 5, 2024
@mfrw mfrw merged commit b600bbc into microsoft:main Feb 6, 2024
@mfrw mfrw mentioned this pull request Feb 21, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants