Skip to content

Add nss-mdns requested by redis team#7956

Merged
0xba1a merged 9 commits into3.0-devfrom
bala/add_nss-mdns
Feb 28, 2024
Merged

Add nss-mdns requested by redis team#7956
0xba1a merged 9 commits into3.0-devfrom
bala/add_nss-mdns

Conversation

@0xba1a
Copy link
Copy Markdown
Member

@0xba1a 0xba1a commented Feb 20, 2024

  • Add new package nss-mdns to Mariner
  • Bring authselect to core as it is direct dependency for nss-mdns
  • Disable translation in authselect as it requires multiple packages to be moved to core
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Add nss-mdns requested by redis team

Change Log
  • Add new package nss-mdns to Mariner
  • Bring authselect to core as it is direct dependency for nss-mdns
  • Disable translation in authselect as it requires multiple packages to be moved to core
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology

@0xba1a 0xba1a requested a review from a team as a code owner February 20, 2024 11:45

%undefine mariner_module_ldflags

Name: nss-mdns
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package was recently contributed by a redis engineer for 2.0
I think that we should ensure all the options are in parity from 2.0.

Reference: #7407

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. No difference other than a release upgrade for Fedora-40 build. There is no diff in the spec file and the two patch files. Signature of the source is also same.

Comment thread SPECS/nss-mdns/nss-mdns.signatures.json
@mfrw mfrw added the 3.0-dev PRs Destined for AzureLinux 3.0 label Feb 21, 2024
Comment thread SPECS/authselect/authselect.spec
@0xba1a 0xba1a merged commit 924e5d3 into 3.0-dev Feb 28, 2024
@0xba1a 0xba1a deleted the bala/add_nss-mdns branch February 28, 2024 08:58
Xiaohong-Deng pushed a commit to Xiaohong-Deng/azurelinux that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants