Skip to content

Split failing and passing tests in the summary. (#7764)#7835

Merged
PawelWMS merged 1 commit intomainfrom
pawelwi/backport_ptests_summary
Feb 13, 2024
Merged

Split failing and passing tests in the summary. (#7764)#7835
PawelWMS merged 1 commit intomainfrom
pawelwi/backport_ptests_summary

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Backport of #7764 to properly display failing ptests in the build summary.

Change Log
Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Local runs.

@PawelWMS PawelWMS requested a review from a team as a code owner February 12, 2024 21:53
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Feb 12, 2024
@mfrw
Copy link
Copy Markdown
Member

mfrw commented Feb 13, 2024

Tested locally as well

@mfrw mfrw added Tools go Pull requests that update Go code labels Feb 13, 2024
@PawelWMS PawelWMS merged commit 53323c8 into main Feb 13, 2024
@PawelWMS PawelWMS deleted the pawelwi/backport_ptests_summary branch February 13, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code main PR Destined for main Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants