Skip to content

Split failing and passing tests in the summary.#7764

Merged
PawelWMS merged 3 commits into3.0-devfrom
pawelwi/3.0_test_summary_fix
Feb 8, 2024
Merged

Split failing and passing tests in the summary.#7764
PawelWMS merged 3 commits into3.0-devfrom
pawelwi/3.0_test_summary_fix

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Feb 8, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

The package build summary was always incorrectly displaying zero test failures when some package tests failed. This change is addressing this bug.

Summary for no failing tests:
image

Summary for failing tests:
image

Change Log
  • Modified the toolkit to correctly count and display the failing ptests.
Does this affect the toolchain?

No.

Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner February 8, 2024 00:22
Comment thread toolkit/tools/scheduler/schedulerutils/buildworker.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants