Skip to content

Made test failures not fail the package build. (CP of #8121)#8130

Merged
PawelWMS merged 1 commit intomainfrom
pawelwi/main/test_builds_fix
Feb 28, 2024
Merged

Made test failures not fail the package build. (CP of #8121)#8130
PawelWMS merged 1 commit intomainfrom
pawelwi/main/test_builds_fix

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Cherry-picking the #8121 fix from fasttrack/2.0.

Change Log
Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Checked in original change.
  • Local test builds.

@PawelWMS PawelWMS requested a review from a team as a code owner February 28, 2024 01:09
@microsoft-github-policy-service microsoft-github-policy-service Bot added the main PR Destined for main label Feb 28, 2024
@PawelWMS PawelWMS merged commit 3249aa8 into main Feb 28, 2024
@PawelWMS PawelWMS deleted the pawelwi/main/test_builds_fix branch February 28, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants