Skip to content

Made test failures not fail the package build.#8121

Merged
PawelWMS merged 4 commits intofasttrack/2.0from
pawelwi/test_builds_fix
Feb 28, 2024
Merged

Made test failures not fail the package build.#8121
PawelWMS merged 4 commits intofasttrack/2.0from
pawelwi/test_builds_fix

Conversation

@PawelWMS
Copy link
Copy Markdown
Contributor

@PawelWMS PawelWMS commented Feb 27, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

My changes in #7764 introduced a bug, which caused ptest failures to fail the whole build. The intended behaviour is for the test failures to be reported in the summary but the package build itself succeed.

The change keeps failing ptests reported as failures but the test nodes themselves are still marked as available, so the top goal node depending on them can unblocked and thus mark the whole build as finished.

Change Log
  • Made test failures not fail the package build.
Does this affect the toolchain?

No.

Associated issues
Test Methodology

@PawelWMS PawelWMS requested a review from a team as a code owner February 27, 2024 22:37
@PawelWMS
Copy link
Copy Markdown
Contributor Author

Overriding pipeline build check - the pipeline is currently down due to infrastructure issues. Relying on the linked buddy build instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants