Made test failures not fail the package build.#8121
Merged
PawelWMS merged 4 commits intofasttrack/2.0from Feb 28, 2024
Merged
Conversation
dmcilvaney
approved these changes
Feb 27, 2024
Contributor
Author
|
Overriding pipeline build check - the pipeline is currently down due to infrastructure issues. Relying on the linked buddy build instead. |
PawelWMS
added a commit
that referenced
this pull request
Feb 28, 2024
12 tasks
PawelWMS
added a commit
that referenced
this pull request
Feb 28, 2024
12 tasks
PawelWMS
added a commit
that referenced
this pull request
Feb 28, 2024
PawelWMS
added a commit
that referenced
this pull request
Feb 29, 2024
Xiaohong-Deng
pushed a commit
to Xiaohong-Deng/azurelinux
that referenced
this pull request
Nov 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
My changes in #7764 introduced a bug, which caused ptest failures to fail the whole build. The intended behaviour is for the test failures to be reported in the summary but the package build itself succeed.
The change keeps failing ptests reported as failures but the test nodes themselves are still marked as available, so the top goal node depending on them can unblocked and thus mark the whole build as finished.
Change Log
Does this affect the toolchain?
No.
Associated issues
Test Methodology